Clean up the Range class and associated usages. The code was

never clear about whether the end of the range was inclusive
or exclusive.  Make it inclusive, but also provide a RangeSize()
function that will generate a Range based on a start and a size.
This, in combination with using the comparison operators, makes
almost all usages of the range not care how it is stored.

base/range.cc:
    Make the end of the range inclusive.

    start/end -> first/last
    (end seems too much like end() in stl)
base/range.hh:
    Make the end of the range inclusive.

    Fix all comparison operators so that they work correctly with
    an inclusive range.  Also, when comparing one range to another
    with <, <=, >, >=, we only look at the beginning of the range
    beacuse x <= y should be the same as x < y || x == y.  (This wasn't
    the case before.)

    Add a few functions for making a range:
    RangeSize is start and size
    RangeEx is start and end where end is exclusive
    RangeIn is start and end where end is inclusive

    start/end -> first/last
    (end seems too much like end() in stl)
dev/alpha_console.cc:
dev/baddev.cc:
dev/ide_ctrl.cc:
dev/ns_gige.cc:
dev/pciconfigall.cc:
dev/pcidev.cc:
dev/tsunami_cchip.cc:
dev/tsunami_io.cc:
dev/tsunami_pchip.cc:
dev/uart.cc:
    Use the RangeSize function to create a range.

--HG--
extra : convert_revision : 29a7eb7fce745680f1c77fefff456c2144bc3994

10 files changed, 43 insertions, 60 deletions

diff --git a/dev/alpha_console.cc b/dev/alpha_console.cc
index 680704b30..964ab442c 100644
--- a/dev/alpha_console.cc
+++ b/dev/alpha_console.cc
@@ -61,12 +61,12 @@ AlphaConsole::AlphaConsole(const string &name, SimConsole *cons, SimpleDisk *d,
                            HierParams *hier, Bus *bus)
     : PioDevice(name), disk(d), console(cons), addr(a)
 {
-    mmu->add_child(this, Range<Addr>(addr, addr + size));
+    mmu->add_child(this, RangeSize(addr, size));
 
     if (bus) {
         pioInterface = newPioInterface(name, hier, bus, this,
                                        &AlphaConsole::cacheAccess);
-        pioInterface->addAddrRange(addr, addr + size);
+        pioInterface->addAddrRange(RangeSize(addr, size));
     }
 
     alphaAccess = new AlphaAccess;
diff --git a/dev/baddev.cc b/dev/baddev.cc
index 7c563e80a..73b082d47 100644
--- a/dev/baddev.cc
+++ b/dev/baddev.cc
@@ -50,12 +50,12 @@ BadDevice::BadDevice(const string &name, Addr a, MemoryController *mmu,
                      HierParams *hier, Bus *bus, const string &devicename)
     : PioDevice(name), addr(a), devname(devicename)
 {
-    mmu->add_child(this, Range<Addr>(addr, addr + size));
+    mmu->add_child(this, RangeSize(addr, size));
 
     if (bus) {
         pioInterface = newPioInterface(name, hier, bus, this,
                                       &BadDevice::cacheAccess);
-        pioInterface->addAddrRange(addr, addr + size - 1);
+        pioInterface->addAddrRange(RangeSize(addr, size));
     }
 
 }
diff --git a/dev/ide_ctrl.cc b/dev/ide_ctrl.cc
index e40248461..dbec6d743 100644
--- a/dev/ide_ctrl.cc
+++ b/dev/ide_ctrl.cc
@@ -377,8 +377,8 @@ IdeController::WriteConfig(int offset, int size, uint32_t data)
         if (BARAddrs[0] != 0) {
             pri_cmd_addr = BARAddrs[0];
             if (pioInterface)
-                pioInterface->addAddrRange(pri_cmd_addr,
-                                           pri_cmd_addr + pri_cmd_size - 1);
+                pioInterface->addAddrRange(RangeSize(pri_cmd_addr,
+                                                     pri_cmd_size));
 
             pri_cmd_addr &= PA_UNCACHED_MASK;
         }
@@ -388,8 +388,8 @@ IdeController::WriteConfig(int offset, int size, uint32_t data)
         if (BARAddrs[1] != 0) {
             pri_ctrl_addr = BARAddrs[1];
             if (pioInterface)
-                pioInterface->addAddrRange(pri_ctrl_addr,
-                                           pri_ctrl_addr + pri_ctrl_size - 1);
+                pioInterface->addAddrRange(RangeSize(pri_ctrl_addr,
+                                                     pri_ctrl_size));
 
             pri_ctrl_addr &= PA_UNCACHED_MASK;
         }
@@ -399,8 +399,8 @@ IdeController::WriteConfig(int offset, int size, uint32_t data)
         if (BARAddrs[2] != 0) {
             sec_cmd_addr = BARAddrs[2];
             if (pioInterface)
-                pioInterface->addAddrRange(sec_cmd_addr,
-                                           sec_cmd_addr + sec_cmd_size - 1);
+                pioInterface->addAddrRange(RangeSize(sec_cmd_addr,
+                                                     sec_cmd_size));
 
             sec_cmd_addr &= PA_UNCACHED_MASK;
         }
@@ -410,8 +410,8 @@ IdeController::WriteConfig(int offset, int size, uint32_t data)
         if (BARAddrs[3] != 0) {
             sec_ctrl_addr = BARAddrs[3];
             if (pioInterface)
-                pioInterface->addAddrRange(sec_ctrl_addr,
-                                           sec_ctrl_addr + sec_ctrl_size - 1);
+                pioInterface->addAddrRange(RangeSize(sec_ctrl_addr,
+                                                     sec_ctrl_size));
 
             sec_ctrl_addr &= PA_UNCACHED_MASK;
         }
@@ -421,7 +421,7 @@ IdeController::WriteConfig(int offset, int size, uint32_t data)
         if (BARAddrs[4] != 0) {
             bmi_addr = BARAddrs[4];
             if (pioInterface)
-                pioInterface->addAddrRange(bmi_addr, bmi_addr + bmi_size - 1);
+                pioInterface->addAddrRange(RangeSize(bmi_addr, bmi_size));
 
             bmi_addr &= PA_UNCACHED_MASK;
         }
@@ -675,15 +675,11 @@ IdeController::unserialize(Checkpoint *cp, const std::string &section)
     UNSERIALIZE_ARRAY(cmd_in_progress, 4);
 
     if (pioInterface) {
-        pioInterface->addAddrRange(pri_cmd_addr, pri_cmd_addr +
-                                   pri_cmd_size - 1);
-        pioInterface->addAddrRange(pri_ctrl_addr, pri_ctrl_addr +
-                                   pri_ctrl_size - 1);
-        pioInterface->addAddrRange(sec_cmd_addr, sec_cmd_addr +
-                                   sec_cmd_size - 1);
-        pioInterface->addAddrRange(sec_ctrl_addr, sec_ctrl_addr +
-                                   sec_ctrl_size - 1);
-        pioInterface->addAddrRange(bmi_addr, bmi_addr + bmi_size - 1);
+        pioInterface->addAddrRange(RangeSize(pri_cmd_addr, pri_cmd_size));
+        pioInterface->addAddrRange(RangeSize(pri_ctrl_addr, pri_ctrl_size));
+        pioInterface->addAddrRange(RangeSize(sec_cmd_addr, sec_cmd_size));
+        pioInterface->addAddrRange(RangeSize(sec_ctrl_addr, sec_ctrl_size));
+        pioInterface->addAddrRange(RangeSize(bmi_addr, bmi_size));
    }
 }
 
diff --git a/dev/ns_gige.cc b/dev/ns_gige.cc
index 9238a7c7e..8eb41e5cc 100644
--- a/dev/ns_gige.cc
+++ b/dev/ns_gige.cc
@@ -344,8 +344,7 @@ NSGigE::WriteConfig(int offset, int size, uint32_t data)
       case PCI0_BASE_ADDR0:
         if (BARAddrs[0] != 0) {
             if (pioInterface)
-                pioInterface->addAddrRange(BARAddrs[0],
-                                           BARAddrs[0] + BARSize[0] - 1);
+                pioInterface->addAddrRange(RangeSize(BARAddrs[0], BARSize[0]));
 
             BARAddrs[0] &= PA_UNCACHED_MASK;
         }
@@ -353,8 +352,7 @@ NSGigE::WriteConfig(int offset, int size, uint32_t data)
       case PCI0_BASE_ADDR1:
         if (BARAddrs[1] != 0) {
             if (pioInterface)
-                pioInterface->addAddrRange(BARAddrs[1],
-                                           BARAddrs[1] + BARSize[1] - 1);
+                pioInterface->addAddrRange(RangeSize(BARAddrs[1], BARSize[1]));
 
             BARAddrs[1] &= PA_UNCACHED_MASK;
         }
@@ -2410,8 +2408,8 @@ NSGigE::unserialize(Checkpoint *cp, const std::string &section)
      * re-add addrRanges to bus bridges
      */
     if (pioInterface) {
-        pioInterface->addAddrRange(BARAddrs[0], BARAddrs[0] + BARSize[0] - 1);
-        pioInterface->addAddrRange(BARAddrs[1], BARAddrs[1] + BARSize[1] - 1);
+        pioInterface->addAddrRange(RangeSize(BARAddrs[0], BARSize[0]));
+        pioInterface->addAddrRange(RangeSize(BARAddrs[1], BARSize[1]));
     }
 }
 
diff --git a/dev/pciconfigall.cc b/dev/pciconfigall.cc
index 740a9b4ac..6fee30c10 100644
--- a/dev/pciconfigall.cc
+++ b/dev/pciconfigall.cc
@@ -50,12 +50,12 @@ PciConfigAll::PciConfigAll(const string &name, Addr a, MemoryController *mmu,
                            HierParams *hier, Bus *bus, Tick pio_latency)
     : PioDevice(name), addr(a)
 {
-    mmu->add_child(this, Range<Addr>(addr, addr + size));
+    mmu->add_child(this, RangeSize(addr, size));
 
     if (bus) {
         pioInterface = newPioInterface(name, hier, bus, this,
                                       &PciConfigAll::cacheAccess);
-        pioInterface->addAddrRange(addr, addr + size - 1);
+        pioInterface->addAddrRange(RangeSize(addr, size));
         pioLatency = pio_latency * bus->clockRatio;
     }
 
diff --git a/dev/pcidev.cc b/dev/pcidev.cc
index 950d98b54..f0ceb40f2 100644
--- a/dev/pcidev.cc
+++ b/dev/pcidev.cc
@@ -184,21 +184,17 @@ PciDev::WriteConfig(int offset, int size, uint32_t data)
 
                     if (word_value & ~0x1) {
                         Addr base_addr = (word_value & ~0x1) + TSUNAMI_PCI0_IO;
-                        Addr base_size = BARSize[barnum]-1;
+                        Addr base_size = BARSize[barnum];
 
                         // It's never been set
                         if (BARAddrs[barnum] == 0)
                             mmu->add_child((FunctionalMemory *)this,
-                                           Range<Addr>(base_addr,
-                                                       base_addr + base_size));
+                                           RangeSize(base_addr, base_size));
                         else
                             mmu->update_child((FunctionalMemory *)this,
-                                              Range<Addr>(BARAddrs[barnum],
-                                                          BARAddrs[barnum] +
-                                                          base_size),
-                                              Range<Addr>(base_addr,
-                                                          base_addr +
-                                                          base_size));
+                                              RangeSize(BARAddrs[barnum],
+                                                        base_size),
+                                              RangeSize(base_addr, base_size));
 
                         BARAddrs[barnum] = base_addr;
                     }
@@ -212,21 +208,17 @@ PciDev::WriteConfig(int offset, int size, uint32_t data)
                         Addr base_addr = (word_value & ~0x3) +
                             TSUNAMI_PCI0_MEMORY;
 
-                        Addr base_size = BARSize[barnum]-1;
+                        Addr base_size = BARSize[barnum];
 
                         // It's never been set
                         if (BARAddrs[barnum] == 0)
                             mmu->add_child((FunctionalMemory *)this,
-                                           Range<Addr>(base_addr,
-                                                       base_addr + base_size));
+                                           RangeSize(base_addr, base_size));
                         else
                             mmu->update_child((FunctionalMemory *)this,
-                                              Range<Addr>(BARAddrs[barnum],
-                                                          BARAddrs[barnum] +
-                                                          base_size),
-                                              Range<Addr>(base_addr,
-                                                          base_addr +
-                                                          base_size));
+                                              RangeSize(BARAddrs[barnum],
+                                                        base_size),
+                                              RangeSize(base_addr, base_size));
 
                         BARAddrs[barnum] = base_addr;
                     }
@@ -273,10 +265,7 @@ PciDev::unserialize(Checkpoint *cp, const std::string &section)
     // Add the MMU mappings for the BARs
     for (int i=0; i < 6; i++) {
         if (BARAddrs[i] != 0)
-            mmu->add_child((FunctionalMemory *)this,
-                           Range<Addr>(BARAddrs[i],
-                                       BARAddrs[i] +
-                                       BARSize[i] - 1));
+            mmu->add_child(this, RangeSize(BARAddrs[i], BARSize[i]));
     }
 }
 
diff --git a/dev/tsunami_cchip.cc b/dev/tsunami_cchip.cc
index b43bb13bd..20b39f21f 100644
--- a/dev/tsunami_cchip.cc
+++ b/dev/tsunami_cchip.cc
@@ -53,7 +53,7 @@ TsunamiCChip::TsunamiCChip(const string &name, Tsunami *t, Addr a,
                            Tick pio_latency)
     : PioDevice(name), addr(a), tsunami(t)
 {
-    mmu->add_child(this, Range<Addr>(addr, addr + size));
+    mmu->add_child(this, RangeSize(addr, size));
 
     for(int i=0; i < Tsunami::Max_CPUs; i++) {
         dim[i] = 0;
@@ -66,7 +66,7 @@ TsunamiCChip::TsunamiCChip(const string &name, Tsunami *t, Addr a,
     if (bus) {
         pioInterface = newPioInterface(name, hier, bus, this,
                                       &TsunamiCChip::cacheAccess);
-        pioInterface->addAddrRange(addr, addr + size - 1);
+        pioInterface->addAddrRange(RangeSize(addr, size));
         pioLatency = pio_latency * bus->clockRatio;
     }
 
diff --git a/dev/tsunami_io.cc b/dev/tsunami_io.cc
index 105e3b5b7..fab1b4b38 100644
--- a/dev/tsunami_io.cc
+++ b/dev/tsunami_io.cc
@@ -164,12 +164,12 @@ TsunamiIO::TsunamiIO(const string &name, Tsunami *t, time_t init_time,
                      Tick pio_latency)
     : PioDevice(name), addr(a), tsunami(t), rtc(t)
 {
-    mmu->add_child(this, Range<Addr>(addr, addr + size));
+    mmu->add_child(this, RangeSize(addr, size));
 
     if (bus) {
         pioInterface = newPioInterface(name, hier, bus, this,
                                        &TsunamiIO::cacheAccess);
-        pioInterface->addAddrRange(addr, addr + size - 1);
+        pioInterface->addAddrRange(RangeSize(addr, size));
         pioLatency = pio_latency * bus->clockRatio;
     }
 
diff --git a/dev/tsunami_pchip.cc b/dev/tsunami_pchip.cc
index 89940fb5a..4c94d12af 100644
--- a/dev/tsunami_pchip.cc
+++ b/dev/tsunami_pchip.cc
@@ -53,7 +53,7 @@ TsunamiPChip::TsunamiPChip(const string &name, Tsunami *t, Addr a,
                            Bus *bus, Tick pio_latency)
     : PioDevice(name), addr(a), tsunami(t)
 {
-    mmu->add_child(this, Range<Addr>(addr, addr + size));
+    mmu->add_child(this, RangeSize(addr, size));
 
     for (int i = 0; i < 4; i++) {
         wsba[i] = 0;
@@ -64,7 +64,7 @@ TsunamiPChip::TsunamiPChip(const string &name, Tsunami *t, Addr a,
     if (bus) {
         pioInterface = newPioInterface(name, hier, bus, this,
                                       &TsunamiPChip::cacheAccess);
-        pioInterface->addAddrRange(addr, addr + size - 1);
+        pioInterface->addAddrRange(RangeSize(addr, size));
         pioLatency = pio_latency * bus->clockRatio;
     }
 
diff --git a/dev/uart.cc b/dev/uart.cc
index f03e3899f..b71ab2d44 100644
--- a/dev/uart.cc
+++ b/dev/uart.cc
@@ -92,13 +92,13 @@ Uart::Uart(const string &name, SimConsole *c, MemoryController *mmu, Addr a,
     : PioDevice(name), addr(a), size(s), cons(c), txIntrEvent(this, TX_INT),
       rxIntrEvent(this, RX_INT), platform(p)
 {
-    mmu->add_child(this, Range<Addr>(addr, addr + size));
+    mmu->add_child(this, RangeSize(addr, size));
 
 
     if (bus) {
         pioInterface = newPioInterface(name, hier, bus, this,
                                       &Uart::cacheAccess);
-        pioInterface->addAddrRange(addr, addr + size - 1);
+        pioInterface->addAddrRange(RangeSize(addr, size));
         pioLatency = pio_latency * bus->clockRatio;
     }