Syscall DPRINTF and warning cleanup.

base/trace.hh:
    Need std:: on DPRINTFR reference to string class.
base/traceflags.py:
    Remove SyscallWarnings trace flag... we should always print warnings
    so nothing undesirable goes unnoticed.  Replaced with (currently unused)
    Syscall flag.
sim/syscall_emul.cc:
    Change SyscallWarning DPRINTFs into warn() calls.
    Uncomment SyscallVerbose DPRINTFs.
sim/syscall_emul.hh:
    Change SyscallWarning DPRINTFs into warn() calls.
    Call fatal() instead of ad-hoc termination.

--HG--
extra : convert_revision : dc6c2ce3691a129f697b6a6ae5d889e2dbaab228

1 files changed, 3 insertions, 10 deletions

diff --git a/sim/syscall_emul.cc b/sim/syscall_emul.cc
index 5abbdfd74..4ae2d2631 100644
--- a/sim/syscall_emul.cc
+++ b/sim/syscall_emul.cc
@@ -61,12 +61,7 @@ SyscallReturn
 unimplementedFunc(SyscallDesc *desc, int callnum, Process *process,
                   ExecContext *xc)
 {
-    cerr << "Error: syscall " << desc->name
-         << " (#" << callnum << ") unimplemented.";
-    cerr << "  Args: " << xc->getSyscallArg(0) << ", " << xc->getSyscallArg(1)
-         << ", ..." << endl;
-
-    abort();
+    fatal("syscall %s (#%d) unimplemented.", desc->name, callnum);
 }
 
 
@@ -74,10 +69,8 @@ SyscallReturn
 ignoreFunc(SyscallDesc *desc, int callnum, Process *process,
            ExecContext *xc)
 {
-    DCOUT(SyscallWarnings) << "Warning: ignoring syscall " << desc->name
-                           << "(" << xc->getSyscallArg(0)
-                           << ", " << xc->getSyscallArg(1)
-                           << ", ...)" << endl;
+    warn("ignoring syscall %s(%d, %d, ...)", desc->name,
+         xc->getSyscallArg(0), xc->getSyscallArg(1));
 
     return 0;
 }