diff options
| author | Gabe Black <gabeblack@google.com> | 2017-05-11 14:11:28 -0700 |
|---|---|---|
| committer | Gabe Black <gabeblack@google.com> | 2017-05-18 16:48:09 +0000 |
| commit | 41ab3e6e7e9b5a5f4427949f9a981cdf2186c88a (patch) | |
| tree | 1b02f07e240b6207c83a55cc297dc0ab599ac85a /src/arch/alpha | |
| parent | 9aadcc797263fc268fdd9f921ddffa473f56d78a (diff) | |
| download | gem5-41ab3e6e7e9b5a5f4427949f9a981cdf2186c88a.tar.xz | |
base: Refactor the GDB code.
The new version modularizes the implementation of the various commands,
gets rid of dynamic allocation of the register cache, fixes some small
style problems, and uses exceptions to simplify error handling internal to
the GDB stub.
Change-Id: Iff3548373ce4adfb99106a810f5713b769df89b2
Reviewed-on: https://gem5-review.googlesource.com/3280
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Boris Shingarov <shingarov@gmail.com>
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com>
Diffstat (limited to 'src/arch/alpha')
| -rw-r--r-- | src/arch/alpha/remote_gdb.cc | 4 | ||||
| -rw-r--r-- | src/arch/alpha/remote_gdb.hh | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/arch/alpha/remote_gdb.cc b/src/arch/alpha/remote_gdb.cc index 8c01005da..a9ec4cf89 100644 --- a/src/arch/alpha/remote_gdb.cc +++ b/src/arch/alpha/remote_gdb.cc @@ -262,12 +262,12 @@ RemoteGDB::write(Addr vaddr, size_t size, const char *data) } -bool +void RemoteGDB::insertHardBreak(Addr addr, size_t len) { warn_once("Breakpoints do not work in Alpha PAL mode.\n" " See PCEventQueue::doService() in cpu/pc_event.cc.\n"); - return BaseRemoteGDB::insertHardBreak(addr, len); + BaseRemoteGDB::insertHardBreak(addr, len); } RemoteGDB::BaseGdbRegCache* diff --git a/src/arch/alpha/remote_gdb.hh b/src/arch/alpha/remote_gdb.hh index 4b71fd23a..38ff91933 100644 --- a/src/arch/alpha/remote_gdb.hh +++ b/src/arch/alpha/remote_gdb.hh @@ -53,7 +53,7 @@ class RemoteGDB : public BaseRemoteGDB bool acc(Addr addr, size_t len); bool write(Addr addr, size_t size, const char *data); - bool insertHardBreak(Addr addr, size_t len); + void insertHardBreak(Addr addr, size_t len) override; class AlphaGdbRegCache : public BaseGdbRegCache { |