misc: Using smart pointers for memory Requests

This patch is changing the underlying type for RequestPtr from Request*
to shared_ptr<Request>. Having memory requests being managed by smart
pointers will simplify the code; it will also prevent memory leakage and
dangling pointers.

Change-Id: I7749af38a11ac8eb4d53d8df1252951e0890fde3
Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/10996
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/src/arch/arm/vtophys.cc b/src/arch/arm/vtophys.cc
index 872867819..3a6731541 100644
--- a/src/arch/arm/vtophys.cc
+++ b/src/arch/arm/vtophys.cc
@@ -70,7 +70,7 @@ try_translate(ThreadContext *tc, Addr addr)
     Fault fault;
     // Set up a functional memory Request to pass to the TLB
     // to get it to translate the vaddr to a paddr
-    Request req(0, addr, 64, 0x40, -1, 0, 0);
+    auto req = std::make_shared<Request>(0, addr, 64, 0x40, -1, 0, 0);
     ArmISA::TLB *tlb;
 
     // Check the TLBs for a translation
@@ -81,14 +81,14 @@ try_translate(ThreadContext *tc, Addr addr)
     // Calling translateFunctional invokes a table-walk if required
     // so we should always succeed
     tlb = static_cast<ArmISA::TLB*>(tc->getDTBPtr());
-    fault = tlb->translateFunctional(&req, tc, BaseTLB::Read, TLB::NormalTran);
+    fault = tlb->translateFunctional(req, tc, BaseTLB::Read, TLB::NormalTran);
     if (fault == NoFault)
-        return std::make_pair(true, req.getPaddr());
+        return std::make_pair(true, req->getPaddr());
 
     tlb = static_cast<ArmISA::TLB*>(tc->getITBPtr());
-    fault = tlb->translateFunctional(&req, tc, BaseTLB::Read, TLB::NormalTran);
+    fault = tlb->translateFunctional(req, tc, BaseTLB::Read, TLB::NormalTran);
     if (fault == NoFault)
-        return std::make_pair(true, req.getPaddr());
+        return std::make_pair(true, req->getPaddr());
 
     return std::make_pair(false, 0);
 }