summaryrefslogtreecommitdiff
path: root/src/arch/power
diff options
context:
space:
mode:
authorBrandon Potter <brandon.potter@amd.com>2018-08-28 10:13:04 -0400
committerBrandon Potter <Brandon.Potter@amd.com>2019-05-21 20:42:38 +0000
commitdd8a7694806e3f816ba688d2094106db68b46b53 (patch)
tree8fc6bcc3e474ae3843779f6d019b296e28a8848b /src/arch/power
parentdd2d44547ddc08ccee9e1465104eff2f43efdec0 (diff)
downloadgem5-dd8a7694806e3f816ba688d2094106db68b46b53.tar.xz
sim-se: change syscall function signature
The system calls had four parameters. One of the parameters is ThreadContext and another is Process. The ThreadContext holds the value of the current process so the Process parameter is redundant since the system call functions already have indirect access. With the old API, it is possible to call into the functions with the wrong supplied Process which could end up being a confusing error. This patch removes the redundancy by forcing access through the ThreadContext field within each system call. Change-Id: Ib43d3f65824f6d425260dfd9f67de1892b6e8b7c Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/12299 Reviewed-by: Brandon Potter <Brandon.Potter@amd.com> Maintainer: Brandon Potter <Brandon.Potter@amd.com> Tested-by: kokoro <noreply+kokoro@google.com>
Diffstat (limited to 'src/arch/power')
-rw-r--r--src/arch/power/linux/process.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/arch/power/linux/process.cc b/src/arch/power/linux/process.cc
index ea0fc9021..58e7eb507 100644
--- a/src/arch/power/linux/process.cc
+++ b/src/arch/power/linux/process.cc
@@ -80,10 +80,10 @@ PowerLinuxObjectFileLoader loader;
/// Target uname() handler.
static SyscallReturn
-unameFunc(SyscallDesc *desc, int callnum, Process *process,
- ThreadContext *tc)
+unameFunc(SyscallDesc *desc, int callnum, ThreadContext *tc)
{
int index = 0;
+ auto process = tc->getProcessPtr();
TypedBufferArg<Linux::utsname> name(process->getSyscallArg(tc, index));
strcpy(name->sysname, "Linux");