diff options
| author | Gabe Black <gabeblack@google.com> | 2018-01-05 15:01:00 -0800 |
|---|---|---|
| committer | Gabe Black <gabeblack@google.com> | 2018-01-20 08:06:56 +0000 |
| commit | 2a15bfd79ced20a6d4cbf0a0a4c2fbb1444b9a44 (patch) | |
| tree | d1fec5a31a00928dc9d5a3f4f05394236187d19c /src/arch/riscv | |
| parent | b1ade08b2da4a0b398b69ea4eb2de35b08941826 (diff) | |
| download | gem5-2a15bfd79ced20a6d4cbf0a0a4c2fbb1444b9a44.tar.xz | |
arch, mem: Make the page table lookup function return a pointer.
This avoids having a copy in the lookup function itself, and the
declaration of a lot of temporary TLB entry pointers in callers. The
gpu TLB seems to have had the most dependence on the original signature
of the lookup function, partially because it was relying on a somewhat
unsafe copy to a TLB entry using a base class pointer type.
Change-Id: I8b1cf494468163deee000002d243541657faf57f
Reviewed-on: https://gem5-review.googlesource.com/7343
Reviewed-by: Gabe Black <gabeblack@google.com>
Maintainer: Gabe Black <gabeblack@google.com>
Diffstat (limited to 'src/arch/riscv')
| -rw-r--r-- | src/arch/riscv/remote_gdb.cc | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/arch/riscv/remote_gdb.cc b/src/arch/riscv/remote_gdb.cc index 4f423fc01..f4e606e27 100644 --- a/src/arch/riscv/remote_gdb.cc +++ b/src/arch/riscv/remote_gdb.cc @@ -156,11 +156,8 @@ RemoteGDB::RemoteGDB(System *_system, ThreadContext *tc, int _port) bool RemoteGDB::acc(Addr va, size_t len) { - TlbEntry entry; - if (FullSystem) - panic("acc not implemented for RISCV FS!"); - else - return context()->getProcessPtr()->pTable->lookup(va, entry); + panic_if(FullSystem, "acc not implemented for RISCV FS!"); + return context()->getProcessPtr()->pTable->lookup(va) != nullptr; } void |