diff options
| author | Steve Reinhardt <steve.reinhardt@amd.com> | 2014-05-31 18:00:23 -0700 |
|---|---|---|
| committer | Steve Reinhardt <steve.reinhardt@amd.com> | 2014-05-31 18:00:23 -0700 |
| commit | 0be64ffe2f4ff8824b3084362706ffbf456ea490 (patch) | |
| tree | 795d803dcfaa3b92faa1155ce2c835daf2d76290 /src/arch/x86 | |
| parent | 2a8088f5aec433b6a1a2330f4fbc29ae28b5ee73 (diff) | |
| download | gem5-0be64ffe2f4ff8824b3084362706ffbf456ea490.tar.xz | |
style: eliminate equality tests with true and false
Using '== true' in a boolean expression is totally redundant,
and using '== false' is pretty verbose (and arguably less
readable in most cases) compared to '!'.
It's somewhat of a pet peeve, perhaps, but I had some time
waiting for some tests to run and decided to clean these up.
Unfortunately, SLICC appears not to have the '!' operator,
so I had to leave the '== false' tests in the SLICC code.
Diffstat (limited to 'src/arch/x86')
| -rw-r--r-- | src/arch/x86/pagetable_walker.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/arch/x86/pagetable_walker.cc b/src/arch/x86/pagetable_walker.cc index 63397a607..0c8dcd442 100644 --- a/src/arch/x86/pagetable_walker.cc +++ b/src/arch/x86/pagetable_walker.cc @@ -233,7 +233,7 @@ Fault Walker::WalkerState::startWalk() { Fault fault = NoFault; - assert(started == false); + assert(!started); started = true; setupWalk(req->getVaddr()); if (timing) { @@ -262,7 +262,7 @@ Fault Walker::WalkerState::startFunctional(Addr &addr, unsigned &logBytes) { Fault fault = NoFault; - assert(started == false); + assert(!started); started = true; setupWalk(addr); |