diff options
author | Gabe Black <gabeblack@google.com> | 2019-11-24 23:25:40 -0800 |
---|---|---|
committer | Gabe Black <gabeblack@google.com> | 2019-12-10 23:58:14 +0000 |
commit | 4670de81004b6bb10cff2cc8c3414d67eda3b0b5 (patch) | |
tree | c1480c041574a077d30ef2a9a5bdf1980b5dab59 /src/arch/x86 | |
parent | 5e295bada66326a2d1a8e04bd4b21fea7c5b9c69 (diff) | |
download | gem5-4670de81004b6bb10cff2cc8c3414d67eda3b0b5.tar.xz |
arch: Get rid of the now unused setSyscallArg.
Setting syscall args isn't really something we need to do in gem5,
since that will be taken care of by the code actually calling the
syscall. We just need to be able to retrieve the value it put there.
Jira Issue: https://gem5.atlassian.net/browse/GEM5-187
Change-Id: I0bb6d5d0207a7892414a722b3788cb70ee509582
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/23174
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Gabe Black <gabeblack@google.com>
Maintainer: Gabe Black <gabeblack@google.com>
Diffstat (limited to 'src/arch/x86')
-rw-r--r-- | src/arch/x86/process.cc | 14 | ||||
-rw-r--r-- | src/arch/x86/process.hh | 2 |
2 files changed, 0 insertions, 16 deletions
diff --git a/src/arch/x86/process.cc b/src/arch/x86/process.cc index 09ff71f52..f0e8ead98 100644 --- a/src/arch/x86/process.cc +++ b/src/arch/x86/process.cc @@ -1069,13 +1069,6 @@ X86_64Process::getSyscallArg(ThreadContext *tc, int &i) } void -X86_64Process::setSyscallArg(ThreadContext *tc, int i, RegVal val) -{ - assert(i < NumArgumentRegs); - return tc->setIntReg(ArgumentReg[i], val); -} - -void X86_64Process::clone(ThreadContext *old_tc, ThreadContext *new_tc, Process *p, RegVal flags) { @@ -1102,13 +1095,6 @@ I386Process::getSyscallArg(ThreadContext *tc, int &i, int width) } void -I386Process::setSyscallArg(ThreadContext *tc, int i, RegVal val) -{ - assert(i < NumArgumentRegs); - return tc->setIntReg(ArgumentReg[i], val); -} - -void I386Process::clone(ThreadContext *old_tc, ThreadContext *new_tc, Process *p, RegVal flags) { diff --git a/src/arch/x86/process.hh b/src/arch/x86/process.hh index 544d5f61f..37545e9d9 100644 --- a/src/arch/x86/process.hh +++ b/src/arch/x86/process.hh @@ -138,7 +138,6 @@ namespace X86ISA RegVal getSyscallArg(ThreadContext *tc, int &i) override; /// Explicitly import the otherwise hidden getSyscallArg using Process::getSyscallArg; - void setSyscallArg(ThreadContext *tc, int i, RegVal val) override; void clone(ThreadContext *old_tc, ThreadContext *new_tc, Process *process, RegVal flags) override; }; @@ -181,7 +180,6 @@ namespace X86ISA Fault *fault) override; RegVal getSyscallArg(ThreadContext *tc, int &i) override; RegVal getSyscallArg(ThreadContext *tc, int &i, int width) override; - void setSyscallArg(ThreadContext *tc, int i, RegVal val) override; void clone(ThreadContext *old_tc, ThreadContext *new_tc, Process *process, RegVal flags) override; }; |