summaryrefslogtreecommitdiff
path: root/src/arch
diff options
context:
space:
mode:
authorGabe Black <gabeblack@google.com>2018-01-14 11:44:04 -0800
committerGabe Black <gabeblack@google.com>2018-01-15 06:13:55 +0000
commit3e8d76e2e23ab23d68e569e9b2c4498a06c19f59 (patch)
tree24cd226f1a7327b4969ceabe65faa44d5353df42 /src/arch
parent5320a97ced43d4452014ff54c0ba45246db90a00 (diff)
downloadgem5-3e8d76e2e23ab23d68e569e9b2c4498a06c19f59.tar.xz
arch: Fix a fatal_if in most of the arch's process classes.
When switching an assert to a fatal while addressing recent review feedback, I forgot to reverse the polarity of the condition, making the fatal fire in exactly the opposite of the conditions it was meant to. Change-Id: Icf49864ef449052bbb0d427dca786006166575c4 Reviewed-on: https://gem5-review.googlesource.com/7381 Reviewed-by: Matthias Jung <jungma@eit.uni-kl.de> Reviewed-by: Jason Lowe-Power <jason@lowepower.com> Maintainer: Jason Lowe-Power <jason@lowepower.com>
Diffstat (limited to 'src/arch')
-rw-r--r--src/arch/alpha/process.cc2
-rw-r--r--src/arch/arm/process.cc2
-rw-r--r--src/arch/mips/process.cc2
-rw-r--r--src/arch/power/process.cc2
-rw-r--r--src/arch/riscv/process.cc2
-rw-r--r--src/arch/sparc/process.cc2
6 files changed, 6 insertions, 6 deletions
diff --git a/src/arch/alpha/process.cc b/src/arch/alpha/process.cc
index bcfe36270..2c6f83309 100644
--- a/src/arch/alpha/process.cc
+++ b/src/arch/alpha/process.cc
@@ -52,7 +52,7 @@ AlphaProcess::AlphaProcess(ProcessParams *params, ObjectFile *objFile)
: Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
objFile)
{
- fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+ fatal_if(params->useArchPT, "Arch page tables not implemented.");
Addr brk_point = objFile->dataBase() + objFile->dataSize() +
objFile->bssSize();
brk_point = roundUp(brk_point, PageBytes);
diff --git a/src/arch/arm/process.cc b/src/arch/arm/process.cc
index 5daa54a1f..aef714ed3 100644
--- a/src/arch/arm/process.cc
+++ b/src/arch/arm/process.cc
@@ -67,7 +67,7 @@ ArmProcess::ArmProcess(ProcessParams *params, ObjectFile *objFile,
objFile),
arch(_arch)
{
- fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+ fatal_if(params->useArchPT, "Arch page tables not implemented.");
}
ArmProcess32::ArmProcess32(ProcessParams *params, ObjectFile *objFile,
diff --git a/src/arch/mips/process.cc b/src/arch/mips/process.cc
index 76f7e869c..62ccd5afe 100644
--- a/src/arch/mips/process.cc
+++ b/src/arch/mips/process.cc
@@ -53,7 +53,7 @@ MipsProcess::MipsProcess(ProcessParams *params, ObjectFile *objFile)
: Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
objFile)
{
- fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+ fatal_if(params->useArchPT, "Arch page tables not implemented.");
// Set up stack. On MIPS, stack starts at the top of kuseg
// user address space. MIPS stack grows down from here
Addr stack_base = 0x7FFFFFFF;
diff --git a/src/arch/power/process.cc b/src/arch/power/process.cc
index 343cd4b4e..22627efe5 100644
--- a/src/arch/power/process.cc
+++ b/src/arch/power/process.cc
@@ -53,7 +53,7 @@ PowerProcess::PowerProcess(ProcessParams *params, ObjectFile *objFile)
: Process(params, new FuncPageTable(params->name, params->pid, PageBytes),
objFile)
{
- fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+ fatal_if(params->useArchPT, "Arch page tables not implemented.");
// Set up break point (Top of Heap)
Addr brk_point = objFile->dataBase() + objFile->dataSize() +
objFile->bssSize();
diff --git a/src/arch/riscv/process.cc b/src/arch/riscv/process.cc
index 44b276a4b..73df5f50d 100644
--- a/src/arch/riscv/process.cc
+++ b/src/arch/riscv/process.cc
@@ -64,7 +64,7 @@ RiscvProcess::RiscvProcess(ProcessParams *params, ObjectFile *objFile) :
PageBytes),
objFile)
{
- fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+ fatal_if(params->useArchPT, "Arch page tables not implemented.");
const Addr stack_base = 0x7FFFFFFFFFFFFFFFL;
const Addr max_stack_size = 8 * 1024 * 1024;
const Addr next_thread_stack_base = stack_base - max_stack_size;
diff --git a/src/arch/sparc/process.cc b/src/arch/sparc/process.cc
index 59ef5c4ac..1fcb6cba3 100644
--- a/src/arch/sparc/process.cc
+++ b/src/arch/sparc/process.cc
@@ -60,7 +60,7 @@ SparcProcess::SparcProcess(ProcessParams *params, ObjectFile *objFile,
objFile),
StackBias(_StackBias)
{
- fatal_if(!params->useArchPT, "Arch page tables not implemented.");
+ fatal_if(params->useArchPT, "Arch page tables not implemented.");
// Initialize these to 0s
fillStart = 0;
spillStart = 0;