summaryrefslogtreecommitdiff
path: root/src/arch
diff options
context:
space:
mode:
authorAndreas Hansson <andreas.hansson@arm.com>2015-05-05 03:22:27 -0400
committerAndreas Hansson <andreas.hansson@arm.com>2015-05-05 03:22:27 -0400
commit554ddc7c074b0d9793a6c4972e1c449a57b94590 (patch)
treefe8018900a41e7b35332154a12f477ca5928aa4c /src/arch
parent14e5b2ea552f05e7a83970af09ed255eb26ab134 (diff)
downloadgem5-554ddc7c074b0d9793a6c4972e1c449a57b94590.tar.xz
arch, cpu: Do not forward snoops to table walker
This patch simplifies the overall CPU by changing the TLB caches such that they do not forward snoops to the table walker port(s). Note that only ARM and X86 are affected. There is no reason for the ports to snoop as they do not actually take any action, and from a performance point of view we are better of not snooping more than we have to. Should it at a later point be required to snoop for a particular TLB design it is easy enough to add it back.
Diffstat (limited to 'src/arch')
-rwxr-xr-xsrc/arch/arm/stage2_mmu.hh34
-rw-r--r--src/arch/x86/pagetable_walker.hh8
2 files changed, 1 insertions, 41 deletions
diff --git a/src/arch/arm/stage2_mmu.hh b/src/arch/arm/stage2_mmu.hh
index 41a10e623..132d1b7f5 100755
--- a/src/arch/arm/stage2_mmu.hh
+++ b/src/arch/arm/stage2_mmu.hh
@@ -57,40 +57,8 @@ class Stage2MMU : public SimObject
protected:
- /**
- * A snooping DMA port that currently does nothing besides
- * extending the DMA port to accept snoops without
- * complaining. Currently we take no action on any snoops.
- */
- class SnoopingDmaPort : public DmaPort
- {
-
- protected:
-
- virtual void recvTimingSnoopReq(PacketPtr pkt)
- { }
-
- virtual Tick recvAtomicSnoop(PacketPtr pkt)
- { return 0; }
-
- virtual void recvFunctionalSnoop(PacketPtr pkt)
- { }
-
- virtual bool isSnooping() const { return true; }
-
- public:
-
- /**
- * A snooping DMA port merely calls the construtor of the DMA
- * port.
- */
- SnoopingDmaPort(MemObject *dev, System *s) :
- DmaPort(dev, s)
- { }
- };
-
/** Port to issue translation requests from */
- SnoopingDmaPort port;
+ DmaPort port;
/** Request id for requests generated by this MMU */
MasterID masterId;
diff --git a/src/arch/x86/pagetable_walker.hh b/src/arch/x86/pagetable_walker.hh
index 181d6fb6c..9be35e6cc 100644
--- a/src/arch/x86/pagetable_walker.hh
+++ b/src/arch/x86/pagetable_walker.hh
@@ -70,15 +70,7 @@ namespace X86ISA
Walker *walker;
bool recvTimingResp(PacketPtr pkt);
-
- /**
- * Snooping a coherence request, do nothing.
- */
- void recvTimingSnoopReq(PacketPtr pkt) { }
- Tick recvAtomicSnoop(PacketPtr pkt) { return 0; }
- void recvFunctionalSnoop(PacketPtr pkt) { }
void recvReqRetry();
- bool isSnooping() const { return true; }
};
friend class WalkerPort;