diff options
| author | Steve Reinhardt <steve.reinhardt@amd.com> | 2014-05-31 18:00:23 -0700 |
|---|---|---|
| committer | Steve Reinhardt <steve.reinhardt@amd.com> | 2014-05-31 18:00:23 -0700 |
| commit | 0be64ffe2f4ff8824b3084362706ffbf456ea490 (patch) | |
| tree | 795d803dcfaa3b92faa1155ce2c835daf2d76290 /src/base/loader | |
| parent | 2a8088f5aec433b6a1a2330f4fbc29ae28b5ee73 (diff) | |
| download | gem5-0be64ffe2f4ff8824b3084362706ffbf456ea490.tar.xz | |
style: eliminate equality tests with true and false
Using '== true' in a boolean expression is totally redundant,
and using '== false' is pretty verbose (and arguably less
readable in most cases) compared to '!'.
It's somewhat of a pet peeve, perhaps, but I had some time
waiting for some tests to run and decided to clean these up.
Unfortunately, SLICC appears not to have the '!' operator,
so I had to leave the '== false' tests in the SLICC code.
Diffstat (limited to 'src/base/loader')
| -rwxr-xr-x | src/base/loader/hex_file.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/base/loader/hex_file.cc b/src/base/loader/hex_file.cc index e26ac31e6..dac013d40 100755 --- a/src/base/loader/hex_file.cc +++ b/src/base/loader/hex_file.cc @@ -104,7 +104,7 @@ HexFile::parseLine(char *Str, Addr *A, uint32_t *D) } else if (Str[i] == ' ' || Str[i] == '\n') { if (Number == 0) return; - if (Flag == false) { + if (!Flag) { *A = Number; Number = 0; Flag = true; @@ -125,7 +125,7 @@ HexFile::parseLine(char *Str, Addr *A, uint32_t *D) i++; } - if (Flag != true) { + if (!Flag) { *A = 0; *D = 0; } else { |