diff options
| author | Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com> | 2018-02-20 00:32:37 +0530 |
|---|---|---|
| committer | Gabe Black <gabeblack@google.com> | 2018-03-15 23:24:51 +0000 |
| commit | 9dc44b4173b72d15fa7ee49d1b196c2d11c84d02 (patch) | |
| tree | a55560518cf4395d1eab583cbeb51d6c06b28dbd /src/base | |
| parent | 5a1e52d5a019c128c4c87783f76f4742c5e4455f (diff) | |
| download | gem5-9dc44b4173b72d15fa7ee49d1b196c2d11c84d02.tar.xz | |
arm: Fix implicit-fallthrough warnings when building with gcc-7+
gcc 7 onwards have additional heuristics to detect implicit
fallthroughs and it fails the build with warnings for ARM as a result.
There was one gcc bug[1] that I fixed but the rest are cases that gcc
cannot detect due to the point at which it does the fallthrough check.
Most of this patch adds __builtin_unreachable() hints in places that throw
this warning to indicate to gcc that the fallthrough will never
happen.
The remaining cases are actually possible fallthroughs due to
incorrect code running on the simulator; in which case an Unknown
instruction is returned.
[1] https://gcc.gnu.org/ml/gcc-patches/2018-02/msg01105.html
Change-Id: I1baa9fa0ed15181c10c755c0bd777f88b607c158
Signed-off-by: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
Reviewed-on: https://gem5-review.googlesource.com/8541
Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Maintainer: Giacomo Travaglini <giacomo.travaglini@arm.com>
Diffstat (limited to 'src/base')
| -rw-r--r-- | src/base/compiler.hh | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/base/compiler.hh b/src/base/compiler.hh index 6920dad10..6b0091410 100644 --- a/src/base/compiler.hh +++ b/src/base/compiler.hh @@ -55,6 +55,7 @@ # define M5_NO_INLINE __attribute__ ((__noinline__)) # define M5_DEPRECATED __attribute__((deprecated)) # define M5_DEPRECATED_MSG(MSG) __attribute__((deprecated(MSG))) +# define M5_UNREACHABLE __builtin_unreachable() #endif #if defined(__clang__) |