diff options
| author | Rekai Gonzalez-Alberquilla <rekai.gonzalezalberquilla@arm.com> | 2017-02-10 17:27:33 +0000 |
|---|---|---|
| committer | Giacomo Travaglini <giacomo.travaglini@arm.com> | 2018-02-13 16:47:44 +0000 |
| commit | 2d6afc6e2621fe67df09d4824ccd678a503b3517 (patch) | |
| tree | c714bc1bc2af3b25b266849c515855b36f1e334e /src/base | |
| parent | e9f736738d61775cd3b739dbc9f85cbf4f4c135f (diff) | |
| download | gem5-2d6afc6e2621fe67df09d4824ccd678a503b3517.tar.xz | |
sim: Make Stats truly non-copy-constructible
The stats are silently non-copy constructible. Therefore, when someone
copy-constructs any object with stats, asserts happen when registering
the stats, as they were not constructed in the intended way.
This patch solves that by explicitly deleting the copy constructor,
trading an obscure run-time assert for a compile-time somehow more
meaningful error meassage.
This triggers some compilation errors as the FaultStats in the fault
definitions of ARM and SPARC use brace-enclosed initialisations in which
one of the elements derives from DataWrap, which is not
copy-constructible anymore. To fix that, this patch also adds a
constructor for the FaultVals in both ISAs.
Change-Id: I340e203b9386609b32c66e3b8918a015afe415a4
Reviewed-by: Curtis Dunham <curtis.dunham@arm.com>
Reviewed-by: Sascha Bischoff <sascha.bischoff@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/8082
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Gabe Black <gabeblack@google.com>
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com>
Diffstat (limited to 'src/base')
| -rw-r--r-- | src/base/statistics.hh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/base/statistics.hh b/src/base/statistics.hh index d0f77297a..3e1758ab8 100644 --- a/src/base/statistics.hh +++ b/src/base/statistics.hh @@ -232,7 +232,7 @@ class DataWrap : public InfoAccess /** * Copy constructor, copies are not allowed. */ - DataWrap(const DataWrap &stat) {} + DataWrap(const DataWrap &stat) = delete; /** * Can't copy stats. |