diff options
| author | Andreas Hansson <andreas.hansson@arm.com> | 2014-09-19 10:35:18 -0400 |
|---|---|---|
| committer | Andreas Hansson <andreas.hansson@arm.com> | 2014-09-19 10:35:18 -0400 |
| commit | 41fc8a573ea61b2463606a0714a9e563494da329 (patch) | |
| tree | c038491b91eb89fa487781bca6ba5b6b1ba65ec3 /src/cpu/checker | |
| parent | 619c5519fe214250d537527ec95191a9b3d6fad2 (diff) | |
| download | gem5-41fc8a573ea61b2463606a0714a9e563494da329.tar.xz | |
arch: Pass faults by const reference where possible
This patch changes how faults are passed between methods in an attempt
to copy as few reference-counting pointer instances as possible. This
should avoid unecessary copies being created, contributing to the
increment/decrement of the reference counters.
Diffstat (limited to 'src/cpu/checker')
| -rw-r--r-- | src/cpu/checker/cpu.hh | 2 | ||||
| -rw-r--r-- | src/cpu/checker/cpu_impl.hh | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/cpu/checker/cpu.hh b/src/cpu/checker/cpu.hh index bf71dc30e..d684b142b 100644 --- a/src/cpu/checker/cpu.hh +++ b/src/cpu/checker/cpu.hh @@ -426,7 +426,7 @@ class Checker : public CheckerCPU void switchOut(); void takeOverFrom(BaseCPU *oldCPU); - void advancePC(Fault fault); + void advancePC(const Fault &fault); void verify(DynInstPtr &inst); diff --git a/src/cpu/checker/cpu_impl.hh b/src/cpu/checker/cpu_impl.hh index b6ec4f77b..9743905c1 100644 --- a/src/cpu/checker/cpu_impl.hh +++ b/src/cpu/checker/cpu_impl.hh @@ -69,7 +69,7 @@ using namespace TheISA; template <class Impl> void -Checker<Impl>::advancePC(Fault fault) +Checker<Impl>::advancePC(const Fault &fault) { if (fault != NoFault) { curMacroStaticInst = StaticInst::nullStaticInstPtr; |