diff options
author | Steve Reinhardt <steve.reinhardt@amd.com> | 2016-01-17 18:27:46 -0800 |
---|---|---|
committer | Steve Reinhardt <steve.reinhardt@amd.com> | 2016-01-17 18:27:46 -0800 |
commit | 707275265f188a514d1d5673ed4c8d6495304962 (patch) | |
tree | c245b55e0efae47759c11e96e703d4c8794c8573 /src/cpu/o3/lsq.hh | |
parent | e595d9cccb3c3a06f915547ecc9b224d65e7d5cc (diff) | |
download | gem5-707275265f188a514d1d5673ed4c8d6495304962.tar.xz |
cpu: remove unnecessary data ptr from O3 internal read() funcs
The read() function merely initiates a memory read operation; the
data doesn't arrive until the access completes and a response packet
is received from the memory system. Thus there's no need to provide
a data pointer; its existence is historical.
Getting this pointer out of this internal o3 interface sets the
stage for similar cleanup in the ExecContext interface. Also
found that we were pointlessly setting the contents at this pointer
on a store forward (the useful memcpy happens just a few lines
below the deleted one).
Diffstat (limited to 'src/cpu/o3/lsq.hh')
-rw-r--r-- | src/cpu/o3/lsq.hh | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/cpu/o3/lsq.hh b/src/cpu/o3/lsq.hh index d726088ef..dcd676221 100644 --- a/src/cpu/o3/lsq.hh +++ b/src/cpu/o3/lsq.hh @@ -275,7 +275,7 @@ class LSQ { * index. */ Fault read(RequestPtr req, RequestPtr sreqLow, RequestPtr sreqHigh, - uint8_t *data, int load_idx); + int load_idx); /** Executes a store operation, using the store specified at the store * index. @@ -332,11 +332,11 @@ class LSQ { template <class Impl> Fault LSQ<Impl>::read(RequestPtr req, RequestPtr sreqLow, RequestPtr sreqHigh, - uint8_t *data, int load_idx) + int load_idx) { ThreadID tid = req->threadId(); - return thread[tid].read(req, sreqLow, sreqHigh, data, load_idx); + return thread[tid].read(req, sreqLow, sreqHigh, load_idx); } template <class Impl> |