diff options
| author | Steve Reinhardt <steve.reinhardt@amd.com> | 2014-05-31 18:00:23 -0700 |
|---|---|---|
| committer | Steve Reinhardt <steve.reinhardt@amd.com> | 2014-05-31 18:00:23 -0700 |
| commit | 0be64ffe2f4ff8824b3084362706ffbf456ea490 (patch) | |
| tree | 795d803dcfaa3b92faa1155ce2c835daf2d76290 /src/cpu/o3/rob_impl.hh | |
| parent | 2a8088f5aec433b6a1a2330f4fbc29ae28b5ee73 (diff) | |
| download | gem5-0be64ffe2f4ff8824b3084362706ffbf456ea490.tar.xz | |
style: eliminate equality tests with true and false
Using '== true' in a boolean expression is totally redundant,
and using '== false' is pretty verbose (and arguably less
readable in most cases) compared to '!'.
It's somewhat of a pet peeve, perhaps, but I had some time
waiting for some tests to run and decided to clean these up.
Unfortunately, SLICC appears not to have the '!' operator,
so I had to leave the '== false' tests in the SLICC code.
Diffstat (limited to 'src/cpu/o3/rob_impl.hh')
| -rw-r--r-- | src/cpu/o3/rob_impl.hh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cpu/o3/rob_impl.hh b/src/cpu/o3/rob_impl.hh index 61d6bd11b..5a9dc90f9 100644 --- a/src/cpu/o3/rob_impl.hh +++ b/src/cpu/o3/rob_impl.hh @@ -519,7 +519,7 @@ ROB<Impl>::readHeadInst(ThreadID tid) if (threadEntries[tid] != 0) { InstIt head_thread = instList[tid].begin(); - assert((*head_thread)->isInROB()==true); + assert((*head_thread)->isInROB()); return *head_thread; } else { |