summaryrefslogtreecommitdiff
path: root/src/cpu/o3
diff options
context:
space:
mode:
authorStephan Diestelhorst <stephan.diestelhorst@arm.com>2015-08-10 11:25:52 +0100
committerStephan Diestelhorst <stephan.diestelhorst@arm.com>2015-08-10 11:25:52 +0100
commitf703160e5a49bf22b831d3a7f3355d7b4b3008fa (patch)
tree8132b091e55a29cbb9e76f9844b794fc8898be43 /src/cpu/o3
parentcabd4768c7186911fda91b9ea458df775b79486a (diff)
downloadgem5-f703160e5a49bf22b831d3a7f3355d7b4b3008fa.tar.xz
mem, cpu: Add assertions to snoop invalidation logic
This patch adds assertions that enforce that only invalidating snoops will ever reach into the logic that tracks in-order load completion and also invalidation of LL/SC (and MONITOR / MWAIT) monitors. Also adds some comments to MSHR::replaceUpgrades().
Diffstat (limited to 'src/cpu/o3')
-rw-r--r--src/cpu/o3/lsq_unit_impl.hh3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/cpu/o3/lsq_unit_impl.hh b/src/cpu/o3/lsq_unit_impl.hh
index b87ab0240..73be5e56f 100644
--- a/src/cpu/o3/lsq_unit_impl.hh
+++ b/src/cpu/o3/lsq_unit_impl.hh
@@ -435,6 +435,9 @@ template <class Impl>
void
LSQUnit<Impl>::checkSnoop(PacketPtr pkt)
{
+ // Should only ever get invalidations in here
+ assert(pkt->isInvalidate());
+
int load_idx = loadHead;
DPRINTF(LSQUnit, "Got snoop for address %#x\n", pkt->getAddr());