diff options
| author | Andreas Hansson <andreas.hansson@arm.com> | 2014-09-19 10:35:18 -0400 |
|---|---|---|
| committer | Andreas Hansson <andreas.hansson@arm.com> | 2014-09-19 10:35:18 -0400 |
| commit | 41fc8a573ea61b2463606a0714a9e563494da329 (patch) | |
| tree | c038491b91eb89fa487781bca6ba5b6b1ba65ec3 /src/cpu/simple/timing.cc | |
| parent | 619c5519fe214250d537527ec95191a9b3d6fad2 (diff) | |
| download | gem5-41fc8a573ea61b2463606a0714a9e563494da329.tar.xz | |
arch: Pass faults by const reference where possible
This patch changes how faults are passed between methods in an attempt
to copy as few reference-counting pointer instances as possible. This
should avoid unecessary copies being created, contributing to the
increment/decrement of the reference counters.
Diffstat (limited to 'src/cpu/simple/timing.cc')
| -rw-r--r-- | src/cpu/simple/timing.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/cpu/simple/timing.cc b/src/cpu/simple/timing.cc index f572fc268..9c8f8b57a 100644 --- a/src/cpu/simple/timing.cc +++ b/src/cpu/simple/timing.cc @@ -328,7 +328,7 @@ TimingSimpleCPU::sendSplitData(RequestPtr req1, RequestPtr req2, } void -TimingSimpleCPU::translationFault(Fault fault) +TimingSimpleCPU::translationFault(const Fault &fault) { // fault may be NoFault in cases where a fault is suppressed, // for instance prefetches. @@ -576,7 +576,8 @@ TimingSimpleCPU::fetch() void -TimingSimpleCPU::sendFetch(Fault fault, RequestPtr req, ThreadContext *tc) +TimingSimpleCPU::sendFetch(const Fault &fault, RequestPtr req, + ThreadContext *tc) { if (fault == NoFault) { DPRINTF(SimpleCPU, "Sending fetch for addr %#x(pa: %#x)\n", @@ -608,7 +609,7 @@ TimingSimpleCPU::sendFetch(Fault fault, RequestPtr req, ThreadContext *tc) void -TimingSimpleCPU::advanceInst(Fault fault) +TimingSimpleCPU::advanceInst(const Fault &fault) { if (_status == Faulting) return; |