diff options
author | Andreas Hansson <andreas.hansson@arm.com> | 2014-09-19 10:35:18 -0400 |
---|---|---|
committer | Andreas Hansson <andreas.hansson@arm.com> | 2014-09-19 10:35:18 -0400 |
commit | 41fc8a573ea61b2463606a0714a9e563494da329 (patch) | |
tree | c038491b91eb89fa487781bca6ba5b6b1ba65ec3 /src/cpu/simple/timing.hh | |
parent | 619c5519fe214250d537527ec95191a9b3d6fad2 (diff) | |
download | gem5-41fc8a573ea61b2463606a0714a9e563494da329.tar.xz |
arch: Pass faults by const reference where possible
This patch changes how faults are passed between methods in an attempt
to copy as few reference-counting pointer instances as possible. This
should avoid unecessary copies being created, contributing to the
increment/decrement of the reference counters.
Diffstat (limited to 'src/cpu/simple/timing.hh')
-rw-r--r-- | src/cpu/simple/timing.hh | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/cpu/simple/timing.hh b/src/cpu/simple/timing.hh index 4a5a20429..a7ea57c67 100644 --- a/src/cpu/simple/timing.hh +++ b/src/cpu/simple/timing.hh @@ -123,7 +123,7 @@ class TimingSimpleCPU : public BaseSimpleCPU } void - finish(Fault fault, RequestPtr req, ThreadContext *tc, + finish(const Fault &fault, RequestPtr req, ThreadContext *tc, BaseTLB::Mode mode) { cpu->sendFetch(fault, req, tc); @@ -135,7 +135,7 @@ class TimingSimpleCPU : public BaseSimpleCPU void sendSplitData(RequestPtr req1, RequestPtr req2, RequestPtr req, uint8_t *data, bool read); - void translationFault(Fault fault); + void translationFault(const Fault &fault); void buildPacket(PacketPtr &pkt, RequestPtr req, bool read); void buildSplitPacket(PacketPtr &pkt1, PacketPtr &pkt2, @@ -280,10 +280,10 @@ class TimingSimpleCPU : public BaseSimpleCPU Addr addr, unsigned flags, uint64_t *res); void fetch(); - void sendFetch(Fault fault, RequestPtr req, ThreadContext *tc); + void sendFetch(const Fault &fault, RequestPtr req, ThreadContext *tc); void completeIfetch(PacketPtr ); void completeDataAccess(PacketPtr pkt); - void advanceInst(Fault fault); + void advanceInst(const Fault &fault); /** This function is used by the page table walker to determine if it could * translate the a pending request or if the underlying request has been |