diff options
| author | Andreas Hansson <andreas.hansson@arm.com> | 2012-08-21 05:50:03 -0400 |
|---|---|---|
| committer | Andreas Hansson <andreas.hansson@arm.com> | 2012-08-21 05:50:03 -0400 |
| commit | 70e99e0b915fa7ed9ac682af6f68f077799ddea7 (patch) | |
| tree | f8554cd3a43fee7e246458b89ee52f5c67686f0c /src/dev/Pci.py | |
| parent | a81c969529d3a1645b490fcde93d231ec997b7ba (diff) | |
| download | gem5-70e99e0b915fa7ed9ac682af6f68f077799ddea7.tar.xz | |
Device: Remove overloaded pio_latency parameter
This patch removes the overloading of the parameter, which seems both
redundant, and possibly incorrect.
The PciConfigAll now also uses a Param.Latency rather than a
Param.Tick. For backwards compatibility it still sets the pio_latency
to 1 tick. All the comments have also been updated to not state that
it is in simticks when it is not necessarily the case.
Diffstat (limited to 'src/dev/Pci.py')
| -rw-r--r-- | src/dev/Pci.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/dev/Pci.py b/src/dev/Pci.py index c866f9386..db2791ed5 100644 --- a/src/dev/Pci.py +++ b/src/dev/Pci.py @@ -34,7 +34,9 @@ from Device import BasicPioDevice, DmaDevice, PioDevice class PciConfigAll(PioDevice): type = 'PciConfigAll' platform = Param.Platform(Parent.any, "Platform this device is part of.") - pio_latency = Param.Tick(1, "Programmed IO latency in simticks") + # @todo: This latency is unrealistically low and only kept at 1 tick + # to not change any regressions + pio_latency = Param.Latency('1t', "Programmed IO latency") bus = Param.UInt8(0x00, "PCI bus to act as config space for") size = Param.MemorySize32('16MB', "Size of config space") @@ -47,7 +49,7 @@ class PciDevice(DmaDevice): pci_bus = Param.Int("PCI bus") pci_dev = Param.Int("PCI device number") pci_func = Param.Int("PCI function code") - pio_latency = Param.Latency('1ns', "Programmed IO latency in simticks") + pio_latency = Param.Latency('1ns', "Programmed IO latency") config_latency = Param.Latency('20ns', "Config read or write latency") VendorID = Param.UInt16("Vendor ID") |