diff options
| author | Steve Reinhardt <stever@gmail.com> | 2013-07-11 21:56:24 -0500 |
|---|---|---|
| committer | Steve Reinhardt <stever@gmail.com> | 2013-07-11 21:56:24 -0500 |
| commit | b0b1c0205c438d382aaec54ee4b79b92e1a5e285 (patch) | |
| tree | f490b704b90dfaba13254565a8d59770b9cddbed /src/dev/Pci.py | |
| parent | 8e54c93222cd69dd4c388adc37cded7b7eebef76 (diff) | |
| download | gem5-b0b1c0205c438d382aaec54ee4b79b92e1a5e285.tar.xz | |
devices: make more classes derive from BasicPioDevice
A couple of devices that have single fixed memory mapped regions
were not derived from BasicPioDevice, when that's exactly
the functionality that BasicPioDevice provides. This patch
gets rid of a little bit of redundant code by making those
devices actually do so.
Also fixed the weird case of X86ISA::Interrupts, where
the class already did derive from BasicPioDevice but
didn't actually use all the features it could have.
Committed by: Nilay Vaish <nilay@cs.wisc.edu>
Diffstat (limited to 'src/dev/Pci.py')
| -rw-r--r-- | src/dev/Pci.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/dev/Pci.py b/src/dev/Pci.py index df7c773c4..a63c329a4 100644 --- a/src/dev/Pci.py +++ b/src/dev/Pci.py @@ -31,14 +31,16 @@ from m5.params import * from m5.proxy import * from Device import BasicPioDevice, DmaDevice, PioDevice -class PciConfigAll(PioDevice): +class PciConfigAll(BasicPioDevice): type = 'PciConfigAll' cxx_header = "dev/pciconfigall.hh" platform = Param.Platform(Parent.any, "Platform this device is part of.") - pio_latency = Param.Latency('30ns', "Programmed IO latency") bus = Param.UInt8(0x00, "PCI bus to act as config space for") size = Param.MemorySize32('16MB', "Size of config space") + pio_latency = '30ns' + pio_addr = 0 # will be overridden by platform-based calculation + class PciDevice(DmaDevice): type = 'PciDevice' |