summaryrefslogtreecommitdiff
path: root/src/dev/mips/malta_cchip.cc
diff options
context:
space:
mode:
authorAndreas Hansson <andreas.hansson@arm.com>2014-12-02 06:07:41 -0500
committerAndreas Hansson <andreas.hansson@arm.com>2014-12-02 06:07:41 -0500
commit5df96cb690168d750ab0fafffd11fb51624374d2 (patch)
treeb8345b3c1b9f5a998a6eca8d68aa0022086b604d /src/dev/mips/malta_cchip.cc
parent0706a252031b3f160bac65fac00b22f8a5ebf4f9 (diff)
downloadgem5-5df96cb690168d750ab0fafffd11fb51624374d2.tar.xz
mem: Remove redundant Packet::allocate calls
This patch cleans up the packet memory allocation confusion. The data is always allocated at the requesting side, when a packet is created (or copied), and there is never a need for any device to allocate any space if it is merely responding to a paket. This behaviour is in line with how SystemC and TLM works as well, thus increasing interoperability, and matching established conventions. The redundant calls to Packet::allocate are removed, and the checks in the function are tightened up to make sure data is only ever allocated once. There are still some oddities in the packet copy constructor where we copy the data pointer if it is static (without ownership), and allocate new space if the data is dynamic (with ownership). The latter is being worked on further in a follow-on patch.
Diffstat (limited to 'src/dev/mips/malta_cchip.cc')
-rwxr-xr-xsrc/dev/mips/malta_cchip.cc1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/dev/mips/malta_cchip.cc b/src/dev/mips/malta_cchip.cc
index fe3336435..dc5211122 100755
--- a/src/dev/mips/malta_cchip.cc
+++ b/src/dev/mips/malta_cchip.cc
@@ -78,7 +78,6 @@ MaltaCChip::read(PacketPtr pkt)
Addr regnum = (pkt->getAddr() - pioAddr) >> 6;
Addr daddr = (pkt->getAddr() - pioAddr);
- pkt->allocate();
switch (pkt->getSize()) {
case sizeof(uint64_t):