dev: Fix ethernet device inheritance structure

The Python wrappers and the C++ should have the same object
structure. If this is not the case, bad things will happen when the
SWIG wrappers cast between an object and any of its base classes. This
was not the case for NSGigE and Sinic devices. This patch makes NSGigE
and Sinic inherit from the new EtherDevBase class, which in turn
inherits from EtherDevice. As a bonus, this removes some duplicated
statistics from the Sinic device.

1 files changed, 5 insertions, 2 deletions

diff --git a/src/dev/ns_gige.hh b/src/dev/ns_gige.hh
index 8032c0623..f4d0171d6 100644
--- a/src/dev/ns_gige.hh
+++ b/src/dev/ns_gige.hh
@@ -118,7 +118,7 @@ class Packet;
 /**
  * NS DP83820 Ethernet device model
  */
-class NSGigE : public EtherDevice
+class NSGigE : public EtherDevBase
 {
   public:
     /** Transmit State Machine states */
@@ -346,7 +346,10 @@ class NSGigE : public EtherDevice
 
   public:
     typedef NSGigEParams Params;
-    const Params *params() const { return (const Params *)_params; }
+    const Params *params() const {
+        return dynamic_cast<const Params *>(_params);
+    }
+
     NSGigE(Params *params);
     ~NSGigE();