diff options
| author | Gabe Black <gabeblack@google.com> | 2019-05-01 20:14:13 -0700 |
|---|---|---|
| committer | Gabe Black <gabeblack@google.com> | 2019-05-29 04:23:46 +0000 |
| commit | 8666440499ef5b175b16efcf9d3a53f0583f0c45 (patch) | |
| tree | 8fa4310dcd56908d5c8efbca3854c7444770c8e7 /src/dev/virtio | |
| parent | d7c4cad240fd4f378d7362da5e9e44b9f0dd80d3 (diff) | |
| download | gem5-8666440499ef5b175b16efcf9d3a53f0583f0c45.tar.xz | |
arch, base, dev, sim: Remove now unnecessary casts from PortProxy methods.
Change-Id: Ia73b2d86a10d02fa09c924a4571477bb5f200eb7
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18572
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
Diffstat (limited to 'src/dev/virtio')
| -rw-r--r-- | src/dev/virtio/base.cc | 4 | ||||
| -rw-r--r-- | src/dev/virtio/base.hh | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/dev/virtio/base.cc b/src/dev/virtio/base.cc index 61dd3069f..347f5089f 100644 --- a/src/dev/virtio/base.cc +++ b/src/dev/virtio/base.cc @@ -81,7 +81,7 @@ VirtDescriptor::update() assert(_index < queue->getSize()); const Addr desc_addr(vq_addr + sizeof(desc) * _index); vring_desc guest_desc; - memProxy->readBlob(desc_addr, (uint8_t *)&guest_desc, sizeof(guest_desc)); + memProxy->readBlob(desc_addr, &guest_desc, sizeof(guest_desc)); desc = vtoh_legacy(guest_desc); DPRINTF(VIO, "VirtDescriptor(%i): Addr: 0x%x, Len: %i, Flags: 0x%x, " @@ -161,7 +161,7 @@ VirtDescriptor::write(size_t offset, const uint8_t *src, size_t size) if (!isOutgoing()) panic("Trying to write to incoming buffer\n"); - memProxy->writeBlob(desc.addr + offset, const_cast<uint8_t *>(src), size); + memProxy->writeBlob(desc.addr + offset, src, size); } void diff --git a/src/dev/virtio/base.hh b/src/dev/virtio/base.hh index ed3b1b431..f4c85afec 100644 --- a/src/dev/virtio/base.hh +++ b/src/dev/virtio/base.hh @@ -492,7 +492,7 @@ public: /** Update the ring buffer header with data from the guest. */ void readHeader() { assert(_base != 0); - _proxy.readBlob(_base, (uint8_t *)&header, sizeof(header)); + _proxy.readBlob(_base, &header, sizeof(header)); header.flags = vtoh_legacy(header.flags); header.index = vtoh_legacy(header.index); } @@ -502,7 +502,7 @@ public: assert(_base != 0); out.flags = htov_legacy(header.flags); out.index = htov_legacy(header.index); - _proxy.writeBlob(_base, (uint8_t *)&out, sizeof(out)); + _proxy.writeBlob(_base, &out, sizeof(out)); } void read() { @@ -511,7 +511,7 @@ public: /* Read and byte-swap the elements in the ring */ T temp[ring.size()]; _proxy.readBlob(_base + sizeof(header), - (uint8_t *)temp, sizeof(T) * ring.size()); + temp, sizeof(T) * ring.size()); for (int i = 0; i < ring.size(); ++i) ring[i] = vtoh_legacy(temp[i]); } @@ -524,7 +524,7 @@ public: for (int i = 0; i < ring.size(); ++i) temp[i] = htov_legacy(ring[i]); _proxy.writeBlob(_base + sizeof(header), - (uint8_t *)temp, sizeof(T) * ring.size()); + temp, sizeof(T) * ring.size()); writeHeader(); } |