summaryrefslogtreecommitdiff
path: root/src/dev
diff options
context:
space:
mode:
authorAndreas Hansson <andreas.hansson@arm.com>2012-10-15 08:12:23 -0400
committerAndreas Hansson <andreas.hansson@arm.com>2012-10-15 08:12:23 -0400
commit93a159875aa081cf3452754b890d83ae7c2bf943 (patch)
treeb9b1859ddcef2053f6a07c6ba7b446395686c023 /src/dev
parentd52adc4eb68c2733f9af4ac68834583c0a555f9d (diff)
downloadgem5-93a159875aa081cf3452754b890d83ae7c2bf943.tar.xz
Fix: Address a few minor issues identified by cppcheck
This patch addresses a number of smaller issues identified by the code inspection utility cppcheck. There are a number of identified leaks in the arm/linux/system.cc (although the function only get's called once so it is not a major problem), a few deletes in dev/x86/i8042.cc that were not array deletes, and sprintfs where the character array had one element less than needed. In the IIC tags there was a function allocating an array of longs which is in fact never used.
Diffstat (limited to 'src/dev')
-rw-r--r--src/dev/x86/i8042.cc8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/dev/x86/i8042.cc b/src/dev/x86/i8042.cc
index 1e6464815..1fc50db15 100644
--- a/src/dev/x86/i8042.cc
+++ b/src/dev/x86/i8042.cc
@@ -490,7 +490,7 @@ X86ISA::PS2Keyboard::serialize(const std::string &base, std::ostream &os)
}
arrayParamOut(os, base + ".outBuffer.elts", buffer,
bufferSize*sizeof(uint8_t));
- delete buffer;
+ delete[] buffer;
}
void
@@ -506,7 +506,7 @@ X86ISA::PS2Keyboard::unserialize(const std::string &base, Checkpoint *cp,
for (int i = 0; i < bufferSize; ++i) {
outBuffer.push(buffer[i]);
}
- delete buffer;
+ delete[] buffer;
}
void
@@ -523,7 +523,7 @@ X86ISA::PS2Mouse::serialize(const std::string &base, std::ostream &os)
}
arrayParamOut(os, base + ".outBuffer.elts", buffer,
bufferSize*sizeof(uint8_t));
- delete buffer;
+ delete[] buffer;
paramOut(os, base + ".status", statusData);
paramOut(os, base + ".resolution", resolution);
paramOut(os, base + ".sampleRate", sampleRate);
@@ -543,7 +543,7 @@ X86ISA::PS2Mouse::unserialize(const std::string &base, Checkpoint *cp,
for (int i = 0; i < bufferSize; ++i) {
outBuffer.push(buffer[i]);
}
- delete buffer;
+ delete[] buffer;
paramIn(cp, section, base + ".status", statusData);
paramIn(cp, section, base + ".resolution", resolution);
paramIn(cp, section, base + ".sampleRate", sampleRate);