diff options
author | Brandon Potter <brandon.potter@amd.com> | 2018-08-28 10:13:04 -0400 |
---|---|---|
committer | Brandon Potter <Brandon.Potter@amd.com> | 2019-05-21 20:42:38 +0000 |
commit | dd8a7694806e3f816ba688d2094106db68b46b53 (patch) | |
tree | 8fc6bcc3e474ae3843779f6d019b296e28a8848b /src/gpu-compute/cl_driver.hh | |
parent | dd2d44547ddc08ccee9e1465104eff2f43efdec0 (diff) | |
download | gem5-dd8a7694806e3f816ba688d2094106db68b46b53.tar.xz |
sim-se: change syscall function signature
The system calls had four parameters. One of the parameters
is ThreadContext and another is Process. The ThreadContext
holds the value of the current process so the Process parameter
is redundant since the system call functions already have
indirect access.
With the old API, it is possible to call into the functions with
the wrong supplied Process which could end up being a confusing
error.
This patch removes the redundancy by forcing access through the
ThreadContext field within each system call.
Change-Id: Ib43d3f65824f6d425260dfd9f67de1892b6e8b7c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/12299
Reviewed-by: Brandon Potter <Brandon.Potter@amd.com>
Maintainer: Brandon Potter <Brandon.Potter@amd.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Diffstat (limited to 'src/gpu-compute/cl_driver.hh')
-rw-r--r-- | src/gpu-compute/cl_driver.hh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/gpu-compute/cl_driver.hh b/src/gpu-compute/cl_driver.hh index 595aa029a..5dbb27d84 100644 --- a/src/gpu-compute/cl_driver.hh +++ b/src/gpu-compute/cl_driver.hh @@ -53,8 +53,8 @@ class ClDriver final : public EmulatedDriver public: ClDriver(ClDriverParams *p); void handshake(GpuDispatcher *_dispatcher); - int open(Process *p, ThreadContext *tc, int mode, int flags); - int ioctl(Process *p, ThreadContext *tc, unsigned req); + int open(ThreadContext *tc, int mode, int flags); + int ioctl(ThreadContext *tc, unsigned req); const char* codeOffToKernelName(uint64_t code_ptr); private: |