summaryrefslogtreecommitdiff
path: root/src/mem/bridge.cc
diff options
context:
space:
mode:
authorAndreas Hansson <andreas.hansson@arm.com>2013-02-19 05:56:06 -0500
committerAndreas Hansson <andreas.hansson@arm.com>2013-02-19 05:56:06 -0500
commit860155a5fc48f983e9af40c19bf8db8250709c26 (patch)
tree18c5c3ccb573182ba8444fae02c2c84f2bb4a3c5 /src/mem/bridge.cc
parent40d0e6c899d5da400c9647496532a8fb1ef64b7b (diff)
downloadgem5-860155a5fc48f983e9af40c19bf8db8250709c26.tar.xz
mem: Enforce strict use of busFirst- and busLastWordTime
This patch adds a check to ensure that the delay incurred by the bus is not simply disregarded, but accounted for by someone. At this point, all the modules do is to zero it out, and no additional time is spent. This highlights where the bus timing is simply dropped instead of being paid for. As a follow up, the locations identified in this patch should add this additional time to the packets in one way or another. For now it simply acts as a sanity check and highlights where the delay is simply ignored. Since no time is added, all regressions remain the same.
Diffstat (limited to 'src/mem/bridge.cc')
-rw-r--r--src/mem/bridge.cc7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/mem/bridge.cc b/src/mem/bridge.cc
index bfe7e795c..1a8437aa1 100644
--- a/src/mem/bridge.cc
+++ b/src/mem/bridge.cc
@@ -141,6 +141,9 @@ Bridge::BridgeMasterPort::recvTimingResp(PacketPtr pkt)
DPRINTF(Bridge, "Request queue size: %d\n", transmitList.size());
+ // @todo: We need to pay for this and not just zero it out
+ pkt->busFirstWordDelay = pkt->busLastWordDelay = 0;
+
slavePort.schedTimingResp(pkt, bridge.clockEdge(delay));
return true;
@@ -171,6 +174,10 @@ Bridge::BridgeSlavePort::recvTimingReq(PacketPtr pkt)
assert(outstandingResponses != respQueueLimit);
++outstandingResponses;
retryReq = false;
+
+ // @todo: We need to pay for this and not just zero it out
+ pkt->busFirstWordDelay = pkt->busLastWordDelay = 0;
+
masterPort.schedTimingReq(pkt, bridge.clockEdge(delay));
}
}