diff options
author | Steve Reinhardt <Steve.Reinhardt@amd.com> | 2008-07-16 11:10:33 -0700 |
---|---|---|
committer | Steve Reinhardt <Steve.Reinhardt@amd.com> | 2008-07-16 11:10:33 -0700 |
commit | 6629d9b2bc58a885bfebce1517fd12483497b6e4 (patch) | |
tree | 22e2bc30405ba483ac571951f49cc77d7e713477 /src/mem/bus.cc | |
parent | 05d8c9acb8a5a985956998fc13551288496e5cdc (diff) | |
download | gem5-6629d9b2bc58a885bfebce1517fd12483497b6e4.tar.xz |
mem: use single BadAddr responder per system.
Previously there was one per bus, which caused some coherence problems
when more than one decided to respond. Now there is just one on
the main memory bus. The default bus responder on all other buses
is now the downstream cache's cpu_side port. Caches no longer need
to do address range filtering; instead, we just have a simple flag
to prevent snoops from propagating to the I/O bus.
Diffstat (limited to 'src/mem/bus.cc')
-rw-r--r-- | src/mem/bus.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/mem/bus.cc b/src/mem/bus.cc index 2eb823051..b9cdff242 100644 --- a/src/mem/bus.cc +++ b/src/mem/bus.cc @@ -219,7 +219,7 @@ Bus::recvTiming(PacketPtr pkt) } } } else { - assert(dest >= 0 && dest < maxId); + assert(dest < maxId); assert(dest != src); // catch infinite loops dest_port_id = dest; if (dest_port_id == defaultId) @@ -238,7 +238,6 @@ Bus::recvTiming(PacketPtr pkt) if (dest_port_id == src) { // Must be forwarded snoop up from below... assert(dest == Packet::Broadcast); - assert(src != defaultId); // catch infinite loops } else { // send to actual target if (!dest_port->sendTiming(pkt)) { |