diff options
| author | Daniel R. Carvalho <odanrc@yahoo.com.br> | 2019-01-24 15:00:18 +0100 |
|---|---|---|
| committer | Daniel Carvalho <odanrc@yahoo.com.br> | 2019-04-19 16:34:00 +0000 |
| commit | 2d84dc46babdcbd6b6f061d3fe3fec34b999ff5c (patch) | |
| tree | 7727de5e51977e3584b4943b2961782eefb329d1 /src/mem/cache/write_queue_entry.hh | |
| parent | d4cee4dc66e175dd6cea7e9bcbe815a7d2d35462 (diff) | |
| download | gem5-2d84dc46babdcbd6b6f061d3fe3fec34b999ff5c.tar.xz | |
mem-cache: Add match functions to QueueEntry
Having the caller decide the matching logic is error-prone, and
frequently ends up with the secure bit being forgotten. This
change adds matching functions to the QueueEntry to avoid this
problem.
As a side effect the signature of findPending has been changed.
Change-Id: I6e494a821c1e6e841ab103ec69632c0e1b269a08
Signed-off-by: Daniel R. Carvalho <odanrc@yahoo.com.br>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/17530
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
Diffstat (limited to 'src/mem/cache/write_queue_entry.hh')
| -rw-r--r-- | src/mem/cache/write_queue_entry.hh | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/mem/cache/write_queue_entry.hh b/src/mem/cache/write_queue_entry.hh index 59714d948..9aaac493c 100644 --- a/src/mem/cache/write_queue_entry.hh +++ b/src/mem/cache/write_queue_entry.hh @@ -179,6 +179,10 @@ class WriteQueueEntry : public QueueEntry, public Printable * @return string with mshr fields */ std::string print() const; + + bool matchBlockAddr(const Addr addr, const bool is_secure) const override; + bool matchBlockAddr(const PacketPtr pkt) const override; + bool conflictAddr(const QueueEntry* entry) const override; }; #endif // __MEM_CACHE_WRITE_QUEUE_ENTRY_HH__ |