diff options
| author | Gabe Black <gabeblack@google.com> | 2018-11-26 17:51:16 -0800 |
|---|---|---|
| committer | Gabe Black <gabeblack@google.com> | 2018-11-27 21:58:24 +0000 |
| commit | 12311c5540e69750b39f1f2e476546cdf05d1f3e (patch) | |
| tree | 56478af783014362be805d560a19d41faed49b65 /src/mem/cache | |
| parent | a66d12c23517a010f5a05efbc2e47d61fba705c9 (diff) | |
| download | gem5-12311c5540e69750b39f1f2e476546cdf05d1f3e.tar.xz | |
arch, base, cpu, gpu, mem: Replace assert(0 or false with panic.
Neither assert(0) nor assert(false) give any hint as to why control
getting to them is bad, and their more descriptive versions,
assert(0 && "description") and assert(false && "description"), jury
rig assert to add an error message when the utility function panic()
already does that directly with better formatting options.
This change replaces that flavor of call to assert with panic, except
in the actual code which processes the formatting that panic uses (to
avoid infinitely recurring error handling), and in some *.sm files
since I don't know what rules those have to follow and don't want to
accidentaly break them.
Change-Id: I8addfbfaf77eaed94ec8191f2ae4efb477cefdd0
Reviewed-on: https://gem5-review.googlesource.com/c/14636
Reviewed-by: Brandon Potter <Brandon.Potter@amd.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
Diffstat (limited to 'src/mem/cache')
| -rw-r--r-- | src/mem/cache/queue.hh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mem/cache/queue.hh b/src/mem/cache/queue.hh index 1d7ce0c07..36ddb96c2 100644 --- a/src/mem/cache/queue.hh +++ b/src/mem/cache/queue.hh @@ -52,6 +52,7 @@ #include <cassert> #include <string> +#include "base/logging.hh" #include "base/trace.hh" #include "base/types.hh" #include "debug/Drain.hh" @@ -108,8 +109,7 @@ class Queue : public Drainable return readyList.insert(i, entry); } } - assert(false); - return readyList.end(); // keep stupid compilers happy + panic("Failed to add to ready list."); } /** The number of entries that are in service. */ |