summaryrefslogtreecommitdiff
path: root/src/mem/cache
diff options
context:
space:
mode:
authorSteve Reinhardt <steve.reinhardt@amd.com>2015-02-11 10:48:53 -0800
committerSteve Reinhardt <steve.reinhardt@amd.com>2015-02-11 10:48:53 -0800
commite57ab463cff5df095fbd10ef046436a20dbb8f3a (patch)
tree58ec9fa8f4d21b152e7353c019f0498a2d8cc8e8 /src/mem/cache
parent89bb03a1a6e56f5bef3e94240e8edf818e667a45 (diff)
downloadgem5-e57ab463cff5df095fbd10ef046436a20dbb8f3a.tar.xz
mem: remove redundant test in in Cache::recvTimingResp()
For some reason we were checking mshr->hasTargets() even though we had already called mshr->getTarget() unconditionally earlier in the same function (which asserts if there are no targets). Get rid of this useless check, and while we're at it get rid of the redundant call to mshr->getTarget(), since we still have the value saved in a local var.
Diffstat (limited to 'src/mem/cache')
-rw-r--r--src/mem/cache/cache_impl.hh6
1 files changed, 1 insertions, 5 deletions
diff --git a/src/mem/cache/cache_impl.hh b/src/mem/cache/cache_impl.hh
index 8a038416e..ab475445e 100644
--- a/src/mem/cache/cache_impl.hh
+++ b/src/mem/cache/cache_impl.hh
@@ -1128,11 +1128,7 @@ Cache<TagStore>::recvTimingResp(PacketPtr pkt)
}
// First offset for critical word first calculations
- int initial_offset = 0;
-
- if (mshr->hasTargets()) {
- initial_offset = mshr->getTarget()->pkt->getOffset(blkSize);
- }
+ int initial_offset = initial_tgt->pkt->getOffset(blkSize);
while (mshr->hasTargets()) {
MSHR::Target *target = mshr->getTarget();