diff options
author | Daniel R. Carvalho <odanrc@yahoo.com.br> | 2018-10-15 11:48:32 +0200 |
---|---|---|
committer | Daniel Carvalho <odanrc@yahoo.com.br> | 2018-11-05 13:35:23 +0000 |
commit | adde4c91f99fa99abbdd23cf97c45de020429d2d (patch) | |
tree | dcc5f09c9c708cd1c3cb0e8295bab2ec4d67ec97 /src/mem/mem_checker_monitor.cc | |
parent | 49798e0eface6ad81f6227ea54980268656819c0 (diff) | |
download | gem5-adde4c91f99fa99abbdd23cf97c45de020429d2d.tar.xz |
mem: Use Packet writing functions instead of memcpy
Classes were using memcpy instead of the Packet functions
created for writing to/from the packet. This allows these
writes to be better checked and tracked.
This also fixes a bug in MemCheckerMonitor, which was using
the incorrect type for the packet pointer.
Change-Id: I5bbc8a24e59464e8219bb6d54af8209e6d4ee1af
Signed-off-by: Daniel R. Carvalho <odanrc@yahoo.com.br>
Reviewed-on: https://gem5-review.googlesource.com/c/13695
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
Diffstat (limited to 'src/mem/mem_checker_monitor.cc')
-rw-r--r-- | src/mem/mem_checker_monitor.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mem/mem_checker_monitor.cc b/src/mem/mem_checker_monitor.cc index c58ac54fa..ee7eb3fcc 100644 --- a/src/mem/mem_checker_monitor.cc +++ b/src/mem/mem_checker_monitor.cc @@ -164,7 +164,7 @@ MemCheckerMonitor::recvTimingReq(PacketPtr pkt) // write. For reads, we have no data yet, so it doesn't make sense to // allocate. pkt_data.reset(new uint8_t[size]); - memcpy(pkt_data.get(), pkt->getConstPtr<uint8_t*>(), size); + pkt->writeData(pkt_data.get()); } // If a cache miss is served by a cache, a monitor near the memory @@ -253,7 +253,7 @@ MemCheckerMonitor::recvTimingResp(PacketPtr pkt) // a read. For writes, we have already given the MemChecker the data on // the request, so it doesn't make sense to allocate on write. pkt_data.reset(new uint8_t[size]); - memcpy(pkt_data.get(), pkt->getConstPtr<uint8_t*>(), size); + pkt->writeData(pkt_data.get()); } if (is_read || is_write) { |