diff options
author | Andreas Hansson <andreas.hansson@arm.com> | 2014-02-23 19:16:16 -0600 |
---|---|---|
committer | Andreas Hansson <andreas.hansson@arm.com> | 2014-02-23 19:16:16 -0600 |
commit | 5755fff99811a334874026c465ccebb9b0627230 (patch) | |
tree | 78e1978de08c9c69eba65efe4ffca35b39210f87 /src/mem/qport.hh | |
parent | 6aafd5cb3fdaf43aeaf71ea47046dfc909eeeb62 (diff) | |
download | gem5-5755fff99811a334874026c465ccebb9b0627230.tar.xz |
ruby: Simplify RubyPort flow control and routing
This patch simplfies the retry logic in the RubyPort, avoiding
redundant attributes, and enforcing more stringent checks on the
interactions with the normal ports. The patch also simplifies the
routing done by the RubyPort, using the port identifiers instead of a
heavy-weight sender state.
The patch also fixes a bug in the sending of responses from PIO
ports. Previously these responses bypassed the queue in the queued
port, and ignored the return value, potentially leading to response
packets being lost.
Committed by: Nilay Vaish <nilay@cs.wisc.edu>
Diffstat (limited to 'src/mem/qport.hh')
-rw-r--r-- | src/mem/qport.hh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mem/qport.hh b/src/mem/qport.hh index 1453418b8..5406ef114 100644 --- a/src/mem/qport.hh +++ b/src/mem/qport.hh @@ -78,8 +78,8 @@ class QueuedSlavePort : public SlavePort * QueuePort constructor. */ QueuedSlavePort(const std::string& name, MemObject* owner, - SlavePacketQueue &queue) : - SlavePort(name, owner), queue(queue) + SlavePacketQueue &queue, PortID id = InvalidPortID) : + SlavePort(name, owner, id), queue(queue) { } virtual ~QueuedSlavePort() { } |