diff options
author | Daniel R. Carvalho <odanrc@yahoo.com.br> | 2018-10-15 12:25:25 +0200 |
---|---|---|
committer | Daniel Carvalho <odanrc@yahoo.com.br> | 2018-11-07 19:34:55 +0000 |
commit | 75035f5674df3e497d69404a9093b852d2ccf7aa (patch) | |
tree | 5d2d82558ca6be524a2bc8c198f72b72c3b2f251 /src/mem/ruby/system/GPUCoalescer.cc | |
parent | cbbdbcbd6850fa7da83f0def9b6f113ec41da0c0 (diff) | |
download | gem5-75035f5674df3e497d69404a9093b852d2ccf7aa.tar.xz |
mem-ruby: Use Packet writing functions instead of memcpy
Classes were using memcpy instead of the Packet functions
created for writing to/from the packet. This allows these
writes to be better checked and tracked.
Change-Id: Iae3fba1351330916ee1d4103809c71e151b1639e
Signed-off-by: Daniel R. Carvalho <odanrc@yahoo.com.br>
Reviewed-on: https://gem5-review.googlesource.com/c/13915
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
Diffstat (limited to 'src/mem/ruby/system/GPUCoalescer.cc')
-rw-r--r-- | src/mem/ruby/system/GPUCoalescer.cc | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/mem/ruby/system/GPUCoalescer.cc b/src/mem/ruby/system/GPUCoalescer.cc index e17bf63fd..8b8c9566f 100644 --- a/src/mem/ruby/system/GPUCoalescer.cc +++ b/src/mem/ruby/system/GPUCoalescer.cc @@ -640,10 +640,8 @@ GPUCoalescer::hitCallback(GPUCoalescerRequest* srequest, (type == RubyRequestType_RMW_Read) || (type == RubyRequestType_Locked_RMW_Read) || (type == RubyRequestType_Load_Linked)) { - memcpy(pkt->getPtr<uint8_t>(), - data.getData(getOffset(request_address), - pkt->getSize()), - pkt->getSize()); + pkt->setData( + data.getData(getOffset(request_address), pkt->getSize())); } else { data.setData(pkt->getPtr<uint8_t>(), getOffset(request_address), pkt->getSize()); @@ -1097,10 +1095,8 @@ GPUCoalescer::atomicCallback(Addr address, if (pkt->getPtr<uint8_t>() && srequest->m_type != RubyRequestType_ATOMIC_NO_RETURN) { /* atomics are done in memory, and return the data *before* the atomic op... */ - memcpy(pkt->getPtr<uint8_t>(), - data.getData(getOffset(request_address), - pkt->getSize()), - pkt->getSize()); + pkt->setData( + data.getData(getOffset(request_address), pkt->getSize())); } else { DPRINTF(MemoryAccess, "WARNING. Data not transfered from Ruby to M5 for type " \ |