summaryrefslogtreecommitdiff
path: root/src/mem/ruby/system/RubyPort.hh
diff options
context:
space:
mode:
authorJoel Hestness <hestness@cs.wisc.edu>2012-09-23 13:57:08 -0500
committerJoel Hestness <hestness@cs.wisc.edu>2012-09-23 13:57:08 -0500
commit4095af5fd600dcd497aae67ab5471de75601d052 (patch)
tree24805680cb82b855ea8d6131570a76c56ff6e9ad /src/mem/ruby/system/RubyPort.hh
parent6427342318a17468ec2bf8cb8a7618d4d195fba4 (diff)
downloadgem5-4095af5fd600dcd497aae67ab5471de75601d052.tar.xz
RubyPort and Sequencer: Fix draining
Fix the drain functionality of the RubyPort to only call drain on child ports during a system-wide drain process, instead of calling each time that a ruby_hit_callback is executed. This fixes the issue of the RubyPort ports being reawakened during the drain simulation, possibly with work they didn't previously have to complete. If they have new work, they may call process on the drain event that they had not registered work for, causing an assertion failure when completing the drain event. Also, in RubyPort, set the drainEvent to NULL when there are no events to be drained. If not set to NULL, the drain loop can result in stale drainEvents used.
Diffstat (limited to 'src/mem/ruby/system/RubyPort.hh')
-rw-r--r--src/mem/ruby/system/RubyPort.hh2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mem/ruby/system/RubyPort.hh b/src/mem/ruby/system/RubyPort.hh
index e57522b5b..bb8ec7852 100644
--- a/src/mem/ruby/system/RubyPort.hh
+++ b/src/mem/ruby/system/RubyPort.hh
@@ -166,7 +166,7 @@ class RubyPort : public MemObject
}
}
- unsigned int getDrainCount(Event *de);
+ unsigned int getChildDrainCount(Event *de);
uint16_t m_port_id;
uint64_t m_request_cnt;