diff options
author | Vincentius Robby <acolyte@umich.edu> | 2007-06-20 14:54:17 -0400 |
---|---|---|
committer | Vincentius Robby <acolyte@umich.edu> | 2007-06-20 14:54:17 -0400 |
commit | d540dde5b4ed38c5aec846282082dd04fce24b78 (patch) | |
tree | 38d1ad4e76ddeacc556449f8e8d85d8fe1c13050 /src/mem | |
parent | f65e2710ecb725f9f44e0e9edd8389f39720cd64 (diff) | |
download | gem5-d540dde5b4ed38c5aec846282082dd04fce24b78.tar.xz |
Removed "adding instead of dividing" trick.
Caused slowdown in performance instead of speeding up.
src/cpu/base.cc:
Removed "adding instead of dividing" trick.
src/mem/bus.cc:
Fixed spelling in comments.
Removed "adding instead of dividing" trick.
--HG--
extra : convert_revision : 65a736f4f09a64e737dc7aeee53b117976330488
Diffstat (limited to 'src/mem')
-rw-r--r-- | src/mem/bus.cc | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/src/mem/bus.cc b/src/mem/bus.cc index 13e545064..806c7ed85 100644 --- a/src/mem/bus.cc +++ b/src/mem/bus.cc @@ -115,11 +115,14 @@ void Bus::occupyBus(PacketPtr pkt) //Bring tickNextIdle up to the present tick //There is some potential ambiguity where a cycle starts, which might make //a difference when devices are acting right around a cycle boundary. Using - //a < allows things which happen exactly on a cycle boundary to take up only - //the following cycle. Anthing that happens later will have to "wait" for - //the end of that cycle, and then start using the bus after that. - while (tickNextIdle < curTick) - tickNextIdle += clock; + //a < allows things which happen exactly on a cycle boundary to take up + //only the following cycle. Anything that happens later will have to "wait" + //for the end of that cycle, and then start using the bus after that. + if (tickNextIdle < curTick) { + tickNextIdle = curTick; + if (tickNextIdle % clock != 0) + tickNextIdle -= (curTick % clock) + clock; + } // The packet will be sent. Figure out how long it occupies the bus, and // how much of that time is for the first "word", aka bus width. @@ -132,10 +135,9 @@ void Bus::occupyBus(PacketPtr pkt) // We're using the "adding instead of dividing" trick again here if (pkt->hasData()) { int dataSize = pkt->getSize(); - for (int transmitted = 0; transmitted < dataSize; - transmitted += width) { + numCycles += dataSize/width; + if (dataSize % width) numCycles++; - } } else { // If the packet didn't have data, it must have been a response. // Those use the bus for one cycle to send their data. |