summaryrefslogtreecommitdiff
path: root/src/mem
diff options
context:
space:
mode:
authorGabe Black <gabeblack@google.com>2017-10-18 21:16:37 -0700
committerNikos Nikoleris <nikos.nikoleris@arm.com>2018-06-19 14:24:25 +0000
commite27448fd0e21dbf4ef77a8bbb33a4053e31cb67d (patch)
tree95d86625aff66c80f96577180de7f4d8d97809d7 /src/mem
parent9494e7d16a18802b756fdc0e814837d5c98bbd86 (diff)
downloadgem5-e27448fd0e21dbf4ef77a8bbb33a4053e31cb67d.tar.xz
mem: Use the caching in the AddrRangeMap class in PhysicalMemory
Use it instead of custom implemented caching. Change-Id: Ie21012a77a3cb6ce57f34f879fa391678913896a Reviewed-on: https://gem5-review.googlesource.com/5244 Reviewed-by: Daniel Carvalho <odanrc@yahoo.com.br> Reviewed-by: Jason Lowe-Power <jason@lowepower.com> Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
Diffstat (limited to 'src/mem')
-rw-r--r--src/mem/physical.cc42
-rw-r--r--src/mem/physical.hh6
2 files changed, 9 insertions, 39 deletions
diff --git a/src/mem/physical.cc b/src/mem/physical.cc
index c7dbb3bcb..fdc88a8c0 100644
--- a/src/mem/physical.cc
+++ b/src/mem/physical.cc
@@ -74,8 +74,7 @@ using namespace std;
PhysicalMemory::PhysicalMemory(const string& _name,
const vector<AbstractMemory*>& _memories,
bool mmap_using_noreserve) :
- _name(_name), rangeCache(addrMap.end()), size(0),
- mmapUsingNoReserve(mmap_using_noreserve)
+ _name(_name), size(0), mmapUsingNoReserve(mmap_using_noreserve)
{
if (mmap_using_noreserve)
warn("Not reserving swap space. May cause SIGSEGV on actual usage\n");
@@ -236,20 +235,7 @@ PhysicalMemory::~PhysicalMemory()
bool
PhysicalMemory::isMemAddr(Addr addr) const
{
- // see if the address is within the last matched range
- if (rangeCache != addrMap.end() && rangeCache->first.contains(addr)) {
- return true;
- } else {
- // lookup in the interval tree
- const auto& r = addrMap.contains(addr);
- if (r == addrMap.end()) {
- // not in the cache, and not in the tree
- return false;
- }
- // the range is in the tree, update the cache
- rangeCache = r;
- return true;
- }
+ return addrMap.contains(addr) != addrMap.end();
}
AddrRangeList
@@ -293,15 +279,9 @@ PhysicalMemory::access(PacketPtr pkt)
{
assert(pkt->isRequest());
Addr addr = pkt->getAddr();
- if (rangeCache != addrMap.end() && rangeCache->first.contains(addr)) {
- rangeCache->second->access(pkt);
- } else {
- // do not update the cache here, as we typically call
- // isMemAddr before calling access
- const auto& m = addrMap.contains(addr);
- assert(m != addrMap.end());
- m->second->access(pkt);
- }
+ const auto& m = addrMap.contains(addr);
+ assert(m != addrMap.end());
+ m->second->access(pkt);
}
void
@@ -309,15 +289,9 @@ PhysicalMemory::functionalAccess(PacketPtr pkt)
{
assert(pkt->isRequest());
Addr addr = pkt->getAddr();
- if (rangeCache != addrMap.end() && rangeCache->first.contains(addr)) {
- rangeCache->second->functionalAccess(pkt);
- } else {
- // do not update the cache here, as we typically call
- // isMemAddr before calling functionalAccess
- const auto& m = addrMap.contains(addr);
- assert(m != addrMap.end());
- m->second->functionalAccess(pkt);
- }
+ const auto& m = addrMap.contains(addr);
+ assert(m != addrMap.end());
+ m->second->functionalAccess(pkt);
}
void
diff --git a/src/mem/physical.hh b/src/mem/physical.hh
index cc733b2d6..3fb3510b8 100644
--- a/src/mem/physical.hh
+++ b/src/mem/physical.hh
@@ -118,11 +118,7 @@ class PhysicalMemory : public Serializable
std::string _name;
// Global address map
- AddrRangeMap<AbstractMemory*> addrMap;
-
- // a mutable cache for the last address map iterator that matched
- // an address
- mutable AddrRangeMap<AbstractMemory*>::const_iterator rangeCache;
+ AddrRangeMap<AbstractMemory*, 1> addrMap;
// All address-mapped memories
std::vector<AbstractMemory*> memories;