MEM: Make port proxies use references rather than pointers

This patch is adding a clearer design intent to all objects that would
not be complete without a port proxy by making the proxies members
rathen than dynamically allocated. In essence, if NULL would not be a
valid value for the proxy, then we avoid using a pointer to make this
clear.

The same approach is used for the methods using these proxies, such as
loadSections, that now use references rather than pointers to better
reflect the fact that NULL would not be an acceptable value (in fact
the code would break and that is how this patch started out).

Overall the concept of "using a reference to express unconditional
composition where a NULL pointer is never valid" could be done on a
much broader scale throughout the code base, but for now it is only
done in the locations affected by the proxies.

1 files changed, 7 insertions, 6 deletions

diff --git a/src/sim/process.hh b/src/sim/process.hh
index 17b530ab8..a5265f5b0 100644
--- a/src/sim/process.hh
+++ b/src/sim/process.hh
@@ -39,6 +39,7 @@
 #include "base/statistics.hh"
 #include "base/types.hh"
 #include "config/the_isa.hh"
+#include "mem/se_translating_port_proxy.hh"
 #include "sim/sim_object.hh"
 #include "sim/syscallreturn.hh"
 
@@ -48,7 +49,6 @@ struct LiveProcessParams;
 class SyscallDesc;
 class System;
 class ThreadContext;
-class SETranslatingPortProxy;
 
 template<class IntType>
 struct AuxVector
@@ -121,17 +121,14 @@ class Process : public SimObject
 
     virtual void initState();
 
-  protected:
-    /// Memory object for initialization (image loading)
-    SETranslatingPortProxy *initVirtMem;
-
   public:
-    PageTable *pTable;
 
     //This id is assigned by m5 and is used to keep process' tlb entries
     //separated.
     uint64_t M5_pid;
 
+    PageTable* pTable;
+
     class FdMap
     {
       public:
@@ -152,6 +149,10 @@ class Process : public SimObject
         void unserialize(Checkpoint *cp, const std::string &section);
     };
 
+  protected:
+    /// Memory proxy for initialization (image loading)
+    SETranslatingPortProxy initVirtMem;
+
   private:
     // file descriptor remapping support
     static const int MAX_FD = 256;    // max legal fd value