diff options
author | Andreas Hansson <andreas.hansson@arm.com> | 2014-11-24 09:03:38 -0500 |
---|---|---|
committer | Andreas Hansson <andreas.hansson@arm.com> | 2014-11-24 09:03:38 -0500 |
commit | d66b14ca61bec95a4049e5aae468904395055efd (patch) | |
tree | 6ddaf6bd4a792f0fe3125d57dae95fb9099dd7b7 /src/sim/syscall_emul.cc | |
parent | 1f539f13c32ad5a9187d56a098d4c857639b0e05 (diff) | |
download | gem5-d66b14ca61bec95a4049e5aae468904395055efd.tar.xz |
misc: Another round of static analysis fixups
Mostly addressing uninitialised members.
Diffstat (limited to 'src/sim/syscall_emul.cc')
-rw-r--r-- | src/sim/syscall_emul.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/sim/syscall_emul.cc b/src/sim/syscall_emul.cc index cb592e338..37d0121c5 100644 --- a/src/sim/syscall_emul.cc +++ b/src/sim/syscall_emul.cc @@ -228,6 +228,7 @@ readFunc(SyscallDesc *desc, int num, LiveProcess *p, ThreadContext *tc) { int index = 0; int fd = p->sim_fd(p->getSyscallArg(tc, index)); + assert(fd >= 0); Addr bufPtr = p->getSyscallArg(tc, index); int nbytes = p->getSyscallArg(tc, index); BufferArg bufArg(bufPtr, nbytes); @@ -264,6 +265,7 @@ lseekFunc(SyscallDesc *desc, int num, LiveProcess *p, ThreadContext *tc) { int index = 0; int fd = p->sim_fd(p->getSyscallArg(tc, index)); + assert(fd >= 0); uint64_t offs = p->getSyscallArg(tc, index); int whence = p->getSyscallArg(tc, index); @@ -278,6 +280,7 @@ _llseekFunc(SyscallDesc *desc, int num, LiveProcess *p, ThreadContext *tc) { int index = 0; int fd = p->sim_fd(p->getSyscallArg(tc, index)); + assert(fd >= 0); uint64_t offset_high = p->getSyscallArg(tc, index); uint32_t offset_low = p->getSyscallArg(tc, index); Addr result_ptr = p->getSyscallArg(tc, index); @@ -301,9 +304,6 @@ _llseekFunc(SyscallDesc *desc, int num, LiveProcess *p, ThreadContext *tc) result_buf.copyOut(tc->getMemProxy()); return 0; } - - - return (result == (off_t)-1) ? -errno : result; } |