diff options
author | Gabe Black <gabeblack@google.com> | 2018-06-13 18:41:27 -0700 |
---|---|---|
committer | Gabe Black <gabeblack@google.com> | 2018-08-15 01:36:01 +0000 |
commit | a51eb91659d759215422c73165ce2a46ccc7a662 (patch) | |
tree | f0cb2ac260bee5bdab5c9708b8f352f0b0515233 /src/systemc/utils/sc_trace_file.cc | |
parent | d8a149bb7dc2446a8d45d4ec4095f8f9bf3df7d3 (diff) | |
download | gem5-a51eb91659d759215422c73165ce2a46ccc7a662.tar.xz |
systemc: Remove references to internal constants from the tests.
The tests were referring to constants defined in the Accellera systemc
implementation which identified various log message types. This change
replaces those (sometimes quite long) string constants with their
actual value. This doesn't make that interface any more fragile since
the constant value won't track between the Accellera version and this
one, but it does make its fragility more explicit by using the value
directly.
If in the future we decide to hide the magical nature of those
particular string constants, we could make them into our own constants
in the implementation. Regardless, the tests shouldn't refer to
internal details of the implementation.
Change-Id: I116a7407fcac49367649b250683117f3ccf4f9ed
Reviewed-on: https://gem5-review.googlesource.com/11181
Reviewed-by: Gabe Black <gabeblack@google.com>
Maintainer: Gabe Black <gabeblack@google.com>
Diffstat (limited to 'src/systemc/utils/sc_trace_file.cc')
0 files changed, 0 insertions, 0 deletions