diff options
author | Steve Reinhardt <steve.reinhardt@amd.com> | 2010-03-23 08:50:59 -0700 |
---|---|---|
committer | Steve Reinhardt <steve.reinhardt@amd.com> | 2010-03-23 08:50:59 -0700 |
commit | f066bfc2f5944353ea11fd4c6853179c4ea1af78 (patch) | |
tree | 8f7591e42f78aa8a21c3553f5dca787b4b4ab4a8 /util/regress | |
parent | 4d77ea7a5783d1de87a8eb804b17a6ef352998ce (diff) | |
download | gem5-f066bfc2f5944353ea11fd4c6853179c4ea1af78.tar.xz |
cpu: get rid of uncached access "events"
These recordEvent() calls could cause crashes since they
access the req pointer after it's potentially been
deleted during a failed translation call. (Similar
problem to the traceData bug fixed in the previous cset.)
Moving them above the translation call (as was done
recentlyi in cset 8b2b8e5e7d35) avoids the crash
but doesn't work, since at that point we don't know if
the access is uncached or not.
It's not clear why these calls are there, and no one
seems to use them, so we'll just delete them. If they
are needed, they should be moved to somewhere that's
guaranteed to be after the translation completes but
before the request is possibly deleted, e.g., in
finishTranslation().
Diffstat (limited to 'util/regress')
0 files changed, 0 insertions, 0 deletions