diff options
Diffstat (limited to 'cpu')
-rw-r--r-- | cpu/simple/atomic.cc | 12 | ||||
-rw-r--r-- | cpu/simple/timing.cc | 13 |
2 files changed, 16 insertions, 9 deletions
diff --git a/cpu/simple/atomic.cc b/cpu/simple/atomic.cc index c09f16ada..e9422b9c0 100644 --- a/cpu/simple/atomic.cc +++ b/cpu/simple/atomic.cc @@ -349,20 +349,16 @@ AtomicSimpleCPU::write(T data, Addr addr, unsigned flags, uint64_t *res) dcache_access = true; assert(data_write_pkt->result == Success); - } - if (res && (fault == NoFault)) - *res = data_write_pkt->result; + if (res && data_write_req->getFlags() & LOCKED) { + *res = data_write_req->getScResult(); + } + } // This will need a new way to tell if it's hooked up to a cache or not. if (data_write_req->getFlags() & UNCACHEABLE) recordEvent("Uncached Write"); - // @todo this is a hack and only works on uniprocessor systems - // some one else can implement LL/SC. - if (data_write_req->getFlags() & LOCKED) - *res = 1; - // If the write needs to have a fault on the access, consider calling // changeStatus() and changing it to "bad addr write" or something. return fault; diff --git a/cpu/simple/timing.cc b/cpu/simple/timing.cc index 80d3380a5..70b88c4b1 100644 --- a/cpu/simple/timing.cc +++ b/cpu/simple/timing.cc @@ -75,6 +75,9 @@ TimingSimpleCPU::CpuPort::recvFunctional(Packet *pkt) void TimingSimpleCPU::CpuPort::recvStatusChange(Status status) { + if (status == RangeChange) + return; + panic("TimingSimpleCPU doesn't expect recvStatusChange callback!"); } @@ -342,6 +345,8 @@ TimingSimpleCPU::write(int32_t data, Addr addr, unsigned flags, uint64_t *res) void TimingSimpleCPU::fetch() { + checkForInterrupts(); + Request *ifetch_req = new Request(true); ifetch_req->setSize(sizeof(MachInst)); @@ -380,7 +385,12 @@ TimingSimpleCPU::completeInst(Fault fault) advancePC(fault); - fetch(); + if (_status == Running) { + // kick off fetch of next instruction... callback from icache + // response will cause that instruction to be executed, + // keeping the CPU running. + fetch(); + } } @@ -397,6 +407,7 @@ TimingSimpleCPU::completeIfetch() Fault fault = curStaticInst->initiateAcc(this, traceData); assert(fault == NoFault); assert(_status == DcacheWaitResponse); + // instruction will complete in dcache response callback } else { // non-memory instruction: execute completely now Fault fault = curStaticInst->execute(this, traceData); |