Bug 693639: Use strlcpy instead of strncpy!

strncpy is *not* the correct function to use. It does not null terminate,
and it needlessly zeroes past the end. It was designed for fixed length
database records, not strings. Use fz_strlcpy and strlcat instead.

1 files changed, 1 insertions, 2 deletions

diff --git a/pdf/pdf_xref.c b/pdf/pdf_xref.c
index c94ad85e..7914876e 100644
--- a/pdf/pdf_xref.c
+++ b/pdf/pdf_xref.c
@@ -1301,8 +1301,7 @@ pdf_meta(pdf_document *doc, int key, void *ptr, int size)
 		if (info && ptr && size)
 		{
 			char *utf8 = pdf_to_utf8(doc, info);
-			strncpy(ptr, utf8, size);
-			((char *)ptr)[size-1] = 0;
+			fz_strlcpy(ptr, utf8, size);
 			fz_free(doc->ctx, utf8);
 		}
 		return 1;