diff options
author | Matt Holgate <matt@emobix.co.uk> | 2014-07-03 14:44:05 +0100 |
---|---|---|
committer | Matt Holgate <matt@emobix.co.uk> | 2014-07-03 14:51:43 +0100 |
commit | 3a24435ce9e22bbda507d1f4862cea0d4391cf96 (patch) | |
tree | a092cb7ea9a1bf1b7bc1d2838ca01b867467c1bc /platform/ios | |
parent | 598e69fb9f793fe1ca5be904d92e8e4da765cc76 (diff) | |
download | mupdf-3a24435ce9e22bbda507d1f4862cea0d4391cf96.tar.xz |
Fix memory leak in MuDocRef.m.
Remember to release self, if we're returning nil from the initialiser.
Also, there is no need for fz_var(doc), because doc is an ivar and
effectively equivalent to 'self->doc'.
Diffstat (limited to 'platform/ios')
-rw-r--r-- | platform/ios/Classes/MuDocRef.m | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/platform/ios/Classes/MuDocRef.m b/platform/ios/Classes/MuDocRef.m index db82bbab..076d633d 100644 --- a/platform/ios/Classes/MuDocRef.m +++ b/platform/ios/Classes/MuDocRef.m @@ -12,13 +12,13 @@ dispatch_sync(queue, ^{}); fz_var(self); - fz_var(doc); fz_try(ctx) { doc = fz_open_document(ctx, aFilename); if (!doc) { + [self release]; self = nil; } else @@ -32,6 +32,7 @@ { if (doc != NULL) fz_close_document(doc); + [self release]; self = nil; } } |