Pass rect and matrix by value in geometry functions.

Several things irk me about passing values as const pointers:

* They can be NULL, which is not a valid value.
* They require explicit temporary variables for storage.
* They don't compose easily in a legible manner, requiring
  weird pointer passing semantics where the variable being assigned
  is hidden as an argument in the innermost function call.
* We can't change the value through the pointer, requiring yet more
  local variables to hold copies of the input value.

In the device interface where we pass a matrix to a function, we often
find ourselves making a local copy of the matrix so we can concatenate
other transforms to it. This copying is a lot of unnecessary busywork
that I hope to eventually avoid by laying the groundwork with this
commit.

This is a rather large API change, so I apologize for the inconvenience,
but I hope the end result and gain in legibility will be worth the pain.

1 files changed, 2 insertions, 2 deletions

diff --git a/source/fitz/link.c b/source/fitz/link.c
index b47fa9ee..0d655371 100644
--- a/source/fitz/link.c
+++ b/source/fitz/link.c
@@ -2,13 +2,13 @@
 #include "fitz-imp.h"
 
 fz_link *
-fz_new_link(fz_context *ctx, const fz_rect *bbox, void *doc, const char *uri)
+fz_new_link(fz_context *ctx, fz_rect bbox, void *doc, const char *uri)
 {
 	fz_link *link;
 
 	link = fz_malloc_struct(ctx, fz_link);
 	link->refs = 1;
-	link->rect = *bbox;
+	link->rect = bbox;
 	link->next = NULL;
 	link->doc = doc; /* don't take reference */
 	link->uri = NULL;