diff options
| author | Tor Andersson <tor.andersson@artifex.com> | 2016-01-06 16:59:07 +0100 |
|---|---|---|
| committer | Tor Andersson <tor.andersson@artifex.com> | 2016-01-08 13:00:45 +0100 |
| commit | d06a3d89a455625cddec47f20cb7a4ef8ea60904 (patch) | |
| tree | a1bf8a51eaf61edba69da651df1cd7c6c4f3d9dd /source/fitz/load-png.c | |
| parent | 50e351e3f2b38618508fe76a379155918507ea75 (diff) | |
| download | mupdf-d06a3d89a455625cddec47f20cb7a4ef8ea60904.tar.xz | |
Fix conditional jump or move depends on uninitialised value.
stm.avail_out is only set if !only_metadata.
Reverse the order of the if tests to silence valgrind.
Diffstat (limited to 'source/fitz/load-png.c')
| -rw-r--r-- | source/fitz/load-png.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/fitz/load-png.c b/source/fitz/load-png.c index 956827c0..41529f22 100644 --- a/source/fitz/load-png.c +++ b/source/fitz/load-png.c @@ -454,7 +454,7 @@ png_read_image(fz_context *ctx, struct info *info, unsigned char *p, unsigned in p += size + 12; total -= size + 12; } - if (stm.avail_out != 0 && !only_metadata) + if (!only_metadata && stm.avail_out != 0) { memset(stm.next_out, 0xff, stm.avail_out); fz_warn(ctx, "missing pixel data in png image; possibly truncated"); |