Initialize variables to appease clang scan-build.

17 files changed, 25 insertions, 24 deletions

diff --git a/source/pdf/pdf-annot.c b/source/pdf/pdf-annot.c
index 43436f22..56681424 100644
--- a/source/pdf/pdf-annot.c
+++ b/source/pdf/pdf-annot.c
@@ -245,7 +245,7 @@ pdf_load_link(fz_context *ctx, pdf_document *doc, pdf_obj *dict, int pagenum, co
 	pdf_obj *obj;
 	fz_rect bbox;
 	char *uri;
-	fz_link *link;
+	fz_link *link = NULL;
 
 	obj = pdf_dict_get(ctx, dict, PDF_NAME_Subtype);
 	if (!pdf_name_eq(ctx, obj, PDF_NAME_Link))
diff --git a/source/pdf/pdf-appearance.c b/source/pdf/pdf-appearance.c
index c5e35d5a..db99adae 100644
--- a/source/pdf/pdf-appearance.c
+++ b/source/pdf/pdf-appearance.c
@@ -1427,7 +1427,7 @@ void pdf_update_combobox_appearance(fz_context *ctx, pdf_document *doc, pdf_obj
 
 void pdf_update_pushbutton_appearance(fz_context *ctx, pdf_document *doc, pdf_obj *obj)
 {
-	fz_rect rect;
+	fz_rect rect = fz_empty_rect;
 	pdf_xobject *form = NULL;
 	fz_buffer *fzbuf = NULL;
 	pdf_obj *tobj = NULL;
diff --git a/source/pdf/pdf-colorspace.c b/source/pdf/pdf-colorspace.c
index 9783d65a..4f910de3 100644
--- a/source/pdf/pdf-colorspace.c
+++ b/source/pdf/pdf-colorspace.c
@@ -166,7 +166,7 @@ base_devicen(const fz_colorspace *cs)
 static fz_colorspace *
 load_devicen(fz_context *ctx, pdf_obj *array)
 {
-	fz_colorspace *cs;
+	fz_colorspace *cs = NULL;
 	struct devicen *devn = NULL;
 	pdf_obj *nameobj = pdf_array_get(ctx, array, 1);
 	pdf_obj *baseobj = pdf_array_get(ctx, array, 2);
diff --git a/source/pdf/pdf-device.c b/source/pdf/pdf-device.c
index 34aab893..a647702e 100644
--- a/source/pdf/pdf-device.c
+++ b/source/pdf/pdf-device.c
@@ -534,7 +534,7 @@ pdf_dev_new_form(fz_context *ctx, pdf_obj **form_ref, pdf_device *pdev, const fz
 {
 	pdf_document *doc = pdev->doc;
 	int num;
-	pdf_obj *group_ref;
+	pdf_obj *group_ref = NULL;
 	pdf_obj *group;
 	pdf_obj *form;
 
diff --git a/source/pdf/pdf-js.c b/source/pdf/pdf-js.c
index aae1ac79..5b1fb670 100644
--- a/source/pdf/pdf-js.c
+++ b/source/pdf/pdf-js.c
@@ -91,6 +91,7 @@ static void app_alert(js_State *J)
 	event.icon_type = js_tointeger(J, 2);
 	event.button_group_type = js_tointeger(J, 3);
 	event.title = js_tostring(J, 4);
+	event.button_pressed = 0; /* WIP WIP WIP IS THIS CORRECT? */
 
 	fz_try(js->ctx)
 		pdf_event_issue_alert(js->ctx, js->doc, &event);
@@ -161,7 +162,7 @@ static void field_getName(js_State *J)
 {
 	pdf_js *js = js_getcontext(J);
 	pdf_obj *field = js_touserdata(J, 0, "Field");
-	char *name;
+	char *name = NULL;
 	fz_try(js->ctx)
 		name = pdf_field_name(js->ctx, js->doc, field);
 	fz_catch(js->ctx)
@@ -179,7 +180,7 @@ static void field_getDisplay(js_State *J)
 {
 	pdf_js *js = js_getcontext(J);
 	pdf_obj *field = js_touserdata(J, 0, "Field");
-	int display;
+	int display = 0;
 	fz_try(js->ctx)
 		display = pdf_field_display(js->ctx, js->doc, field);
 	fz_catch(js->ctx)
@@ -279,7 +280,7 @@ static void field_getBorderStyle(js_State *J)
 {
 	pdf_js *js = js_getcontext(J);
 	pdf_obj *field = js_touserdata(J, 0, "Field");
-	const char *border_style;
+	const char *border_style = NULL;
 	fz_try(js->ctx)
 		border_style = pdf_field_border_style(js->ctx, js->doc, field);
 	fz_catch(js->ctx)
@@ -302,7 +303,7 @@ static void field_getValue(js_State *J)
 {
 	pdf_js *js = js_getcontext(J);
 	pdf_obj *field = js_touserdata(J, 0, "Field");
-	char *val;
+	char *val = NULL;
 
 	fz_try(js->ctx)
 		val = pdf_field_value(js->ctx, js->doc, field);
@@ -383,7 +384,7 @@ static void doc_getField(js_State *J)
 	fz_context *ctx = js->ctx;
 	const char *cName = js_tostring(J, 1);
 	char *name = pdf_from_utf8(ctx, cName);
-	pdf_obj *dict;
+	pdf_obj *dict = NULL;
 
 	fz_try(ctx)
 		dict = pdf_lookup_field(ctx, js->form, name);
diff --git a/source/pdf/pdf-layer.c b/source/pdf/pdf-layer.c
index d7f8df4f..acbe6b9a 100644
--- a/source/pdf/pdf-layer.c
+++ b/source/pdf/pdf-layer.c
@@ -617,7 +617,7 @@ pdf_is_hidden_ocg(fz_context *ctx, pdf_ocg_descriptor *desc, pdf_obj *rdb, const
 	{
 		/* An Optional Content Membership Dictionary */
 		pdf_obj *name;
-		int combine, on;
+		int combine, on = 0;
 
 		obj = pdf_dict_get(ctx, ocg, PDF_NAME_VE);
 		if (pdf_is_array(ctx, obj)) {
diff --git a/source/pdf/pdf-object.c b/source/pdf/pdf-object.c
index d6c7d8e3..c490bb69 100644
--- a/source/pdf/pdf-object.c
+++ b/source/pdf/pdf-object.c
@@ -1801,7 +1801,7 @@ int pdf_obj_parent_num(fz_context *ctx, pdf_obj *obj)
 
 pdf_obj *pdf_new_obj_from_str(fz_context *ctx, pdf_document *doc, const char *src)
 {
-	pdf_obj *result;
+	pdf_obj *result = NULL;
 	pdf_lexbuf lexbuf;
 	fz_stream *stream = fz_open_memory(ctx, (unsigned char *)src, strlen(src));
 
diff --git a/source/pdf/pdf-op-buffer.c b/source/pdf/pdf-op-buffer.c
index 6974fb00..6382d71e 100644
--- a/source/pdf/pdf-op-buffer.c
+++ b/source/pdf/pdf-op-buffer.c
@@ -928,7 +928,7 @@ pdf_new_output_processor(fz_context *ctx, fz_output *out, int ahxencode)
 pdf_processor *
 pdf_new_buffer_processor(fz_context *ctx, fz_buffer *buffer, int ahxencode)
 {
-	pdf_processor *proc;
+	pdf_processor *proc = NULL;
 	fz_output *out = fz_new_output_with_buffer(ctx, buffer);
 	fz_try(ctx)
 	{
diff --git a/source/pdf/pdf-op-run.c b/source/pdf/pdf-op-run.c
index f088139e..324ee32d 100644
--- a/source/pdf/pdf-op-run.c
+++ b/source/pdf/pdf-op-run.c
@@ -1218,7 +1218,7 @@ pdf_run_xobject(fz_context *ctx, pdf_run_processor *proc, pdf_xobject *xobj, pdf
 	pdf_obj *resources;
 	fz_rect xobj_bbox;
 	fz_matrix xobj_matrix;
-	int transparency;
+	int transparency = 0;
 	pdf_document *doc;
 	fz_colorspace *cs = NULL;
 
diff --git a/source/pdf/pdf-page.c b/source/pdf/pdf-page.c
index cb60634c..5b319e3a 100644
--- a/source/pdf/pdf-page.c
+++ b/source/pdf/pdf-page.c
@@ -312,7 +312,7 @@ pdf_lookup_page_number(fz_context *ctx, pdf_document *doc, pdf_obj *page)
 int
 pdf_lookup_anchor(fz_context *ctx, pdf_document *doc, const char *name, float *xp, float *yp)
 {
-	pdf_obj *needle, *dest;
+	pdf_obj *needle, *dest = NULL;
 	char *uri;
 
 	if (xp) *xp = 0;
@@ -342,7 +342,7 @@ static pdf_obj *
 pdf_lookup_inherited_page_item(fz_context *ctx, pdf_obj *node, pdf_obj *key)
 {
 	pdf_obj *node2 = node;
-	pdf_obj *val;
+	pdf_obj *val = NULL;
 
 	/* fz_var(node); Not required as node passed in */
 
diff --git a/source/pdf/pdf-parse.c b/source/pdf/pdf-parse.c
index 084ffc19..e4715a26 100644
--- a/source/pdf/pdf-parse.c
+++ b/source/pdf/pdf-parse.c
@@ -186,7 +186,7 @@ pdf_load_stream_as_utf8(fz_context *ctx, pdf_obj *src)
 	fz_buffer *stmbuf;
 	unsigned char *srcptr;
 	size_t srclen;
-	char *dst;
+	char *dst = NULL;
 
 	stmbuf = pdf_load_stream(ctx, src);
 	srclen = fz_buffer_storage(ctx, stmbuf, &srcptr);
diff --git a/source/pdf/pdf-portfolio.c b/source/pdf/pdf-portfolio.c
index 896aff61..08dc1b61 100644
--- a/source/pdf/pdf-portfolio.c
+++ b/source/pdf/pdf-portfolio.c
@@ -614,7 +614,7 @@ int pdf_add_portfolio_entry(fz_context *ctx, pdf_document *doc,
 				const char *filename, int filename_len,
 				const char *unifile, int unifile_len, fz_buffer *buf)
 {
-	int entry, len;
+	int len, entry = 0;
 	pdf_obj *ef, *f, *params, *s;
 	pdf_obj *key;
 	pdf_obj *val = NULL;
diff --git a/source/pdf/pdf-repair.c b/source/pdf/pdf-repair.c
index 91bbca1a..4e8b4bdf 100644
--- a/source/pdf/pdf-repair.c
+++ b/source/pdf/pdf-repair.c
@@ -52,7 +52,7 @@ pdf_repair_obj(fz_context *ctx, pdf_document *doc, pdf_lexbuf *buf, fz_off_t *st
 
 	if (tok == PDF_TOK_OPEN_DICT)
 	{
-		pdf_obj *dict, *obj;
+		pdf_obj *obj, *dict = NULL;
 
 		fz_try(ctx)
 		{
diff --git a/source/pdf/pdf-stream.c b/source/pdf/pdf-stream.c
index 3650bd66..2cb54183 100644
--- a/source/pdf/pdf-stream.c
+++ b/source/pdf/pdf-stream.c
@@ -443,7 +443,7 @@ pdf_load_raw_stream_number(fz_context *ctx, pdf_document *doc, int num)
 	fz_stream *stm;
 	pdf_obj *dict;
 	int len;
-	fz_buffer *buf;
+	fz_buffer *buf = NULL;
 	pdf_xref_entry *x;
 
 	if (num > 0 && num < pdf_xref_len(ctx, doc))
diff --git a/source/pdf/pdf-type3.c b/source/pdf/pdf-type3.c
index 9701cf54..074e3c36 100644
--- a/source/pdf/pdf-type3.c
+++ b/source/pdf/pdf-type3.c
@@ -30,7 +30,7 @@ pdf_load_type3_font(fz_context *ctx, pdf_document *doc, pdf_obj *rdb, pdf_obj *d
 	int i, k, n;
 	fz_rect bbox;
 	fz_matrix matrix;
-	fz_font *font;
+	fz_font *font = NULL;
 
 	fz_var(fontdesc);
 
diff --git a/source/pdf/pdf-write.c b/source/pdf/pdf-write.c
index d2ad560c..27ff94d6 100644
--- a/source/pdf/pdf-write.c
+++ b/source/pdf/pdf-write.c
@@ -648,7 +648,7 @@ static void removeduplicateobjs(fz_context *ctx, pdf_document *doc, pdf_write_st
 		for (other = 1; other < num; other++)
 		{
 			pdf_obj *a, *b;
-			int differ, newnum, streama, streamb;
+			int newnum, streama = 0, streamb = 0, differ = 0;
 
 			if (num == other || !opts->use_list[num] || !opts->use_list[other])
 				continue;
diff --git a/source/pdf/pdf-xref.c b/source/pdf/pdf-xref.c
index cba27397..0f3f56b1 100644
--- a/source/pdf/pdf-xref.c
+++ b/source/pdf/pdf-xref.c
@@ -676,7 +676,7 @@ pdf_xref_size_from_old_trailer(fz_context *ctx, pdf_document *doc, pdf_lexbuf *b
 	fz_off_t t;
 	pdf_token tok;
 	int c;
-	int size;
+	int size = 0;
 	fz_off_t ofs;
 	pdf_obj *trailer = NULL;
 	size_t n;
@@ -969,7 +969,7 @@ pdf_read_new_xref(fz_context *ctx, pdf_document *doc, pdf_lexbuf *buf)
 	pdf_obj *trailer = NULL;
 	pdf_obj *index = NULL;
 	pdf_obj *obj = NULL;
-	int num, gen;
+	int gen, num = 0;
 	fz_off_t ofs, stm_ofs;
 	int size, w0, w1, w2;
 	int t;
@@ -2663,7 +2663,7 @@ pdf_add_object(fz_context *ctx, pdf_document *doc, pdf_obj *obj)
 pdf_obj *
 pdf_add_object_drop(fz_context *ctx, pdf_document *doc, pdf_obj *obj)
 {
-	pdf_obj *ind;
+	pdf_obj *ind = NULL;
 	fz_try(ctx)
 		ind = pdf_add_object(ctx, doc, obj);
 	fz_always(ctx)