diff options
| author | Nico Weber <thakis@chromium.org> | 2015-09-16 13:53:42 -0700 |
|---|---|---|
| committer | Nico Weber <thakis@chromium.org> | 2015-09-16 13:53:42 -0700 |
| commit | 6f34355e9d091fd4e031e9354fdfa778000b0d4a (patch) | |
| tree | 837088269e45b19aff2196800bc72f705a83ea50 | |
| parent | 455019ca48f60bd285e043986471f51f17c69a0d (diff) | |
| download | pdfium-chromium/2513.tar.xz | |
Make pdfium_embeddertests link in debug component builds.chromium/2516chromium/2515chromium/2514chromium/2513chromium/2512chromium/2511
Target v8 has:
'direct_dependent_settings': {
'defines': [
'V8_SHARED',
'USING_V8_SHARED',
],
},
For this to work, targets using v8 headers have to depend on v8
directly, else the V8_EXPORT macro won't work. Add a direct
dependency on v8.
BUG=none
TEST=do a debug component build of pdfium_embeddertests on Win,
should work without linker errors
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1349843002 .
| -rw-r--r-- | BUILD.gn | 1 | ||||
| -rw-r--r-- | pdfium.gyp | 1 |
2 files changed, 2 insertions, 0 deletions
@@ -776,6 +776,7 @@ test("pdfium_embeddertests") { deps = [ "//testing/gmock", "//testing/gtest", + "//v8", "//v8:v8_libplatform", ":pdfium", ] diff --git a/pdfium.gyp b/pdfium.gyp index 5c8799e9a5..12314d7e93 100644 --- a/pdfium.gyp +++ b/pdfium.gyp @@ -731,6 +731,7 @@ 'dependencies': [ '<(DEPTH)/testing/gmock.gyp:gmock', '<(DEPTH)/testing/gtest.gyp:gtest', + '<(DEPTH)/v8/tools/gyp/v8.gyp:v8', '<(DEPTH)/v8/tools/gyp/v8.gyp:v8_libplatform', 'pdfium', ], |