diff options
| author | Jane <janeliulwq@google.com> | 2017-05-23 15:11:45 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-05-23 19:59:39 +0000 |
| commit | e0f1310795f1cf886b9b2a134b28ace9e8fc25ba (patch) | |
| tree | 13cf1ba296a9f83c434decb132896fed5b529a4d | |
| parent | fb71fbb8e8e48047fd6a8f86ad7e59a9846a2784 (diff) | |
| download | pdfium-e0f1310795f1cf886b9b2a134b28ace9e8fc25ba.tar.xz | |
Minor updates to README
Bug:
Change-Id: Ibfaa5f528834fb21c77684b9f4921f17ce4b5789
Reviewed-on: https://pdfium-review.googlesource.com/5811
Commit-Queue: Jane Liu <janeliulwq@google.com>
Reviewed-by: dsinclair <dsinclair@chromium.org>
| -rw-r--r-- | README.md | 13 |
1 files changed, 11 insertions, 2 deletions
@@ -58,6 +58,12 @@ gclient sync cd pdfium ``` +Additional build dependencies need to be installed by running: + +``` +./build/install-build-deps.sh +``` + ## Generate the build files We use GN to generate the build files and @@ -76,7 +82,7 @@ This will launch an editor in which you can set the following arguments. A typical `<directory>` name is `out/Debug`. ``` -use_goma = true # Googlers only. +use_goma = true # Googlers only. Make sure goma is installed and running first. is_debug = true # Enable debugging features. pdf_use_skia = false # Set true to enable experimental skia backend. @@ -154,7 +160,10 @@ and add the "Cr-Internals-Plugins-PDF" label. For contributing code, we will follow [Chromium's process](http://dev.chromium.org/developers/contributing-code) -as much as possible. The main exceptions is: +as much as possible. The main exceptions are: 1. Code has to conform to the existing style and not Chromium/Google style. +2. PDFium uses a different tool for code reviews, and credentials for +the tool need to be generated before uploading a CL. + |