summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNico Weber <thakis@chromium.org>2018-02-15 18:56:41 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-02-15 18:56:41 +0000
commit60027a205953e95b230f289118448b55f12f9a94 (patch)
tree29be599dc445c0fb936ff4cb5e12fd70d34ce856
parent5b097c73dec7e7979166b3396efcf9e001b42b9e (diff)
downloadpdfium-60027a205953e95b230f289118448b55f12f9a94.tar.xz
Actually enable -Wimplicit-fallthrough for pdfium.
I forgot to do this in https://pdfium-review.googlesource.com/c/pdfium/+/26210 which made PDFium compile with the warning enabled. Bug: 807632 Change-Id: Id12e3df3073f3b9550d5bc9dfea0068088496f8a Reviewed-on: https://pdfium-review.googlesource.com/26910 Reviewed-by: dsinclair <dsinclair@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
-rw-r--r--BUILD.gn4
1 files changed, 0 insertions, 4 deletions
diff --git a/BUILD.gn b/BUILD.gn
index bdadebd400..fd18f13953 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -71,10 +71,6 @@ config("pdfium_common_config") {
# Assume UTF-8 by default to avoid code page dependencies.
cflags += [ "/utf-8" ]
}
- if (is_clang) {
- # TODO(thakis): Consider enabling this, https://crbug.com/807632
- cflags += [ "-Wno-implicit-fallthrough" ]
- }
}
config("pdfium_core_config") {